Repository navigation
feat: complete the components barrel for sibling apps (#259) - #262
ayushsingh82 wants to merge 3 commits into
Conversation
Make the Module Federation "./components" expose a complete design-system barrel. - Export every generic primitive from the barrel (avatar, checkbox, dropdown-menu, markdown, navigation-menu, radio-group, select, separator, sheet, sonner, table, textarea, tooltip, data-table, aspect-ratio, segmented-filter, social icons, ...). - Port the primitives sibling apps need but this app lacked, on the existing tokens: field, spinner, stepper, sidebar, breadcrumb, toggle, toggle-group, info-row. - Move app-specific components (api key manager, member card, ...) out of the barrel; the two files that imported them through it now use direct imports. - Add a /design-system route that renders the full primitive set from the barrel.
| }: { | ||
| label: string; | ||
| value: ReactNode; | ||
| mono?: boolean; |
There was a problem hiding this comment.
Remove anything from /ui that isn't a shadcn component
There was a problem hiding this comment.
Append any shadcn components here that feedback app needs -- this may mean doing a full shadcn init to grab all components
There was a problem hiding this comment.
@elliotBraem done in 8140f68: the non-shadcn components (info-row, back-button, data-table, markdown, stepper, etc.) moved out of ui/ into components/common/, and the barrel and all imports are updated. PR: #262
There was a problem hiding this comment.
@elliotBraem added the missing shadcn components (accordion, alert, alert-dialog, calendar, command, drawer, popover, switch, slider, pagination, input-group, combobox and more) and exported them from the barrel in 8140f68. PR: #262
| FieldGroup, | ||
| FieldLabel, | ||
| GithubIcon, | ||
| InfoRow, |
There was a problem hiding this comment.
Hmmmm, could we maybe move this to /brand/design-system instead of here?
There was a problem hiding this comment.
@elliotBraem moved to /brand/design-system (brand.tsx is now brand/index.tsx, with a link to it from the brand page) in 8140f68. PR: #262
…to /brand - move non-shadcn components from ui/ to components/common/ - add missing shadcn components and export them from the barrel - move /design-system to /brand/design-system
2 participants
Refs #259. #258 (canonical style pass) is still open and this was built without it; the ported primitives use the existing tokens, which already cover everything they need.
What changed
./componentsModule Federation expose now exports every generic primitive: avatar, checkbox, dropdown-menu, markdown, navigation-menu, radio-group, select, separator, sheet, sonner, table, textarea, tooltip, data-table, aspect-ratio, segmented-filter and social icons, alongside what it already had. 162 names in total.radix-uidependency, so no new packages.ConfirmDialogstays, as a generic dialog pattern; happy to move it out if you prefer./design-systemroute (noindex) renders the full primitive set from the barrel.Verification
oxlint-disable-next-linecomments with reasons, in the repo's existing style.Not done
./components) is a separate change and is not in this PR.