You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Multiple std::cout statements were added for debugging (lines 747-752). These should be removed or replaced with proper logging mechanisms before merging.
Two test cases were removed without clear explanation. The removed tests (FusionScheduleTransposeRepro1_CUDA and BroadcastingRNGSmemNonSquareTile) may have been testing important scenarios that should either be updated to work with the new swizzle logic or replaced with equivalent tests.
The new shared memory swizzle logic (lines 1352-1373) needs validation to ensure it correctly handles bank conflicts across different tile sizes and vectorization factors. The conditions for disabling swizzle (lines 976-979) should be thoroughly tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.