You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Standardizes include ordering and converts LLVM includes from quotes to angle brackets across host_ir jit/tensor utils.
Adds an empty line separating ATen/c10 includes from LLVM includes in jit_external.cpp.
Switches several nvfuser/project includes in host_ir/ops* and jit_tensor_utils.h from <...> to "...", and reorders those include blocks.
Confidence Score: 4/5
This PR is likely safe to merge, but verify include-path assumptions for headers switched from <...> to "..." in installed/out-of-tree builds.
Changes are largely mechanical include-style updates. The only plausible merge blocker is if switching project headers from angle brackets to quotes changes include resolution under certain build configurations (e.g., installed headers vs in-tree compilation). No functional code changes observed in the diff.
Include reordering and standardization (LLVM headers to <>; runtime/driver includes regrouped).
csrc/host_ir/jit_external.cpp
Standardizes LLVM include quote style and adds blank line between c10 and LLVM include groups.
csrc/host_ir/jit_external.h
Switches LLVM LLJIT include to angle brackets for consistency.
csrc/host_ir/jit_tensor_utils.cpp
Converts LLVM includes to angle brackets; no functional changes.
csrc/host_ir/jit_tensor_utils.h
Switches LLVM includes to <> and changes project header includes from <> to quotes (ir/all_nodes.h, type.h).
csrc/host_ir/ops.cpp
Changes project includes from <> to quotes and reorders; potential risk if build expects <> for exported include paths.
csrc/host_ir/ops.h
Changes host_ir/ir.h and ir/interface_nodes.h includes from <> to quotes; may break installs that rely on -I include paths only.
Sequence Diagram
sequenceDiagram
participant Dev as Developer/Build
participant Compiler as C++ Compiler
participant HostIR as host_ir (jit/ops)
participant LLVM as LLVM headers
participant NVF as nvfuser headers
Dev->>Compiler: Compile csrc/host_ir/*.cpp
Compiler->>HostIR: Process #include directives
HostIR->>LLVM: Include <llvm/...> (system-style)
HostIR->>NVF: Include "..." (project headers)
Compiler-->>Dev: Build succeeds iff include paths resolve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing