Repository navigation
Conversation
Signed-off-by: Shiju <shiju@nvidia.com>
Signed-off-by: Shiju <shiju@nvidia.com>
|
Label |
shiju-nv
marked this pull request as draft
November 8, 2026 19:09
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve VM requirements against the selected backend's capabilities and allow CPU-only QEMU launches with external kernels. Keep PCI/GPU assignment separate, reject unsupported host/kernel/transport inputs before compute starts, and preserve the assigned GPU through before-launch hooks.
Related Issue
Closes #5372
Prerequisite: #5376, which fixes #5373. This branch includes that patch so the new direct-kernel path has the required guest bootstrap setup. Merge the fd-link fix first.
Changes
Release Notes
Testing
All 282 VM crate library tests passed on macOS, along with scoped all-targets Clippy and formatting. Three targeted mutations restored the old CPU/GPU restrictions or disabled the GPU-hook guard; each matching regression failed as expected. Tests cover CPU-only kernel selection and QEMU arguments, explicit conflicts, invalid kernel headers, both launcher modes, unsupported hosts and post-hook GPU assignment.
Fern docs and navigation checks passed with three warnings in unchanged gateway MDX, remote redirect access and theme contrast. The prerequisite fd patch passed its seven-case Linux namespace regression and fresh Firecracker/libkrun Ready/exec integration checks. Actual CPU-only QEMU Ready on Linux x86_64/KVM has not been tested on this Mac.
Checklist