fix(ci): make buildkitd-config opt-in for setup-buildx#970
Merged
Conversation
#966 hard-coded `buildkitd-config: /etc/buildkit/buildkitd.toml` inside the `driver: local` branch of the setup-buildx composite action. The only caller using that driver is shadow-docker-build.yml, which runs inside the ghcr.io/nvidia/openshell/ci:latest container — so the host-side buildkitd.toml was invisible to docker/setup-buildx-action and every matrix job failed at "Set up buildx". Revert the hard-coded path and expose it as an opt-in input on the action (empty default, passed through to both the remote and local branches). Wire shadow-docker-build.yml to bind-mount /etc/buildkit into the ci container and pass the path explicitly, so the action can read the file from inside the container. Remote-driver callers are unaffected (empty input is a no-op). Signed-off-by: Jonas Toelke <jtoelke@nvidia.com>
pimlock
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hotfix for #966, which broke
shadow-docker-build.ymlon main. That PR hard-codedbuildkitd-config: /etc/buildkit/buildkitd.tomlinside thedriver: localbranch of thesetup-buildxcomposite action. The only caller using that driver isshadow-docker-build.yml, which runs inside theghcr.io/nvidia/openshell/ci:latestcontainer — so the host-side TOML was invisible todocker/setup-buildx-actionand every matrix job failed at "Set up buildx" (e.g. run 24911395318).Remote-driver callers (
docker-build,release-dev,release-tag,release-vm-dev,ci-image) were unaffected because the hard-coded line was only inside the local-driver branch.Changes
.github/actions/setup-buildx/action.ymlbuildkitd-configinput (empty default).docker/setup-buildx-actionin both the remote and local branches. Empty input is a no-op..github/workflows/shadow-docker-build.yml/etc/buildkit:/etc/buildkit:rointo the ci container so the action running inside it can read the TOML.buildkitd-config: /etc/buildkit/buildkitd.tomlthrough the new input.Testing
docker/setup-buildx-actionreceives an emptybuildkitd-config, treated as no config)./etc/buildkit/buildkitd.tomlfrom inside the container via the bind mount; will confirm on the first push-to-main dispatch after merge.Related