Repository navigation
Use the services key in the pair-github-pr release-intent examples - #120
Merged
Noah-Tervalon-Nvidia merged 1 commit intoSep 28, 2026
Conversation
The release-intent parser expects the keys in services/versions.json, where the suite version is "services". The skill still told agents to write "product", so both of its example blocks failed validate_pr.py. Signed-off-by: Som Tripathi <somtri@iastate.edu>
Noah-Tervalon-Nvidia
self-requested a review
September 28, 2026 16:23
Noah-Tervalon-Nvidia
approved these changes
Sep 28, 2026
Noah-Tervalon-Nvidia
left a comment
Noah-Tervalon-Nvidia
left a comment
Collaborator
There was a problem hiding this comment.
whoops, not sure how I missed that. Thanks for catching it!
6 of 7 tasks
Noah-Tervalon-Nvidia
pushed a commit
that referenced
this pull request
Oct 9, 2026
## Description
Adds two pages to the public docs: **Release Notes**, starting with
1.0.0, and an **Upgrade Guide** for updating from a version before
1.0.0. People who read the docs rather than GitHub had no release notes
to look at.
The 1.0.0 notes are adapted from the release notes master doc. The
Upgrade Guide starts from the fact that most machines need nothing
extra, then covers the few setups that need a small step:
- tidying up the old `PAIR.app` on macOS;
- an LM Studio that an earlier PAIR installed;
- browser clients affected by the CORS change.
<!-- pair-release-intent:v1 -->
### Changelog title
n/a
### Changelog body
n/a
### Bumps
- services: none
- nvpair-cluster-manager: none
- nvpair-engine-manager: none
- nvpair-errors: none
- nvpair-job-scheduler: none
- nvpair-manual-nodes: none
- nvpair-node-info: none
- nvpair-node-scanner: none
- nvpair-node-settings: none
- nvpair-proxy: none
- nvpair-tui: none
- nvpair-ui-broker: none
- nvpair-workload-manager: none
<!-- /pair-release-intent:v1 -->
## Scope
- `docs/release-notes.mdx` (new): the 1.0.0 notes, covering what's new,
compatibility notes, targeted bug fixes, community contributions with PR
links, and special thanks. Notes before 1.0.0 are linked on GitHub
Releases.
- `docs/upgrade-guide.mdx` (new). It opens by saying an update keeps
settings, cluster membership, and models, and that every machine in a
cluster should run the same version. Each section then says who it
applies to:
- **On macOS, tidy up the old app:** run the old app's
`uninstall-macos.sh` without `--purge`, then install `NVIDIA PAIR.app`.
0.1.0 and 0.1.1 both ship that script, and both keep data without
`--purge`.
- **If an earlier PAIR installed LM Studio for you:** it keeps working,
but it has no install marker (`installed-by-pair.json`), so Uninstall,
Reset app data, and uninstalling PAIR leave it. Steps to remove it while
keeping `models`, or to reinstall it so PAIR manages it.
- **If you use PAIR from a web page or browser extension:** which launch
option allows a site for each engine.
- **Checking everything is working.**
- `fern/docs.yml`: both pages under Guides, after Getting Started.
- `README.md`, `docs/getting-started.mdx` ("Keeping PAIR Up to Date" and
"Learn More"), and `docs/known-issues.mdx`: link to the new pages.
`known-issues` gains an entry for the LM Studio limitation.
## Validation
- Each upgrade step was checked against the code:
`desktop/scripts/build/macos/uninstall.sh` at HEAD, `v0.1.0`, and
`v0.1.1`; `services/nvpair-engine-manager/install.go` and
`provenance.go`; `manifests/lmstudio.json`;
`desktop/docs/macos-privileged-helper.md`; and
`docs/engine-settings.mdx` for the CORS controls.
- Contributor PRs #27, #34, #37, #62, #80, #95, #120, #122, and #126
were checked for merge state and author.
- `node scripts/spdx-headers.mjs`
- `python3 scripts/release-intent/validate_pr.py --description-file
<this description> --skip-owned-files-check`
## Risk
Documentation only. No code, build, or versioned file changes.
Left for the product owner to confirm against the master doc:
- The app is named **NVIDIA PAIR** (`NVIDIA PAIR.app`).
- The macOS note does not say models could be lost, because models never
live inside the app.
- The bug-fix line names LM Studio only, because llama.cpp never shipped
publicly.
- `README.md` and `known-issues.mdx` still call Windows on ARM
experimental, beside the RTX Spark validation note.
## Checklist
- [x] I have read the [Contributing
Guidelines](https://github.com/NVIDIA/Personal-AI-Router/blob/main/CONTRIBUTING.md).
- [x] Every commit is signed off (`git commit -s`), certifying the
[Developer Certificate of Origin](https://developercertificate.org/).
- [ ] New or existing tests cover the change. (Documentation only.)
- [x] Relevant documentation is updated.
- [x] I checked the diff, changed filenames, and commit messages for
credentials, private data, internal URLs, internal issue identifiers,
and generated artifacts.
- [x] I recorded the validation commands and results above.
- [x] I declared version bumps in the release-intent block above.
`services/versions.json` is written by automation — do not edit it by
hand.
---------
Signed-off-by: Chris Kelsey <ckelsey@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.cursor/skills/pair-github-pr/SKILL.mdstill uses the pre-#87productbump key. The parser expects the keys inservices/versions.json, where the suite version isservices. The PR template andservices/VERSIONING.mdalready useservices.Both example blocks in the skill fail the check on
develop:This renames the key in the two examples, the key-list note, the severity rule, and one example heading. The severity rule also drops "product" from "UI-only product notes". No other wording changes.
Release intent
Changelog title
n/a
Changelog body
n/a
Bumps
Scope
Included:
.cursor/skills/pair-github-pr/SKILL.mdonly.Excluded:
services/nvpair-cluster-manager/spec.mdandservices/nvpair-job-scheduler/spec.mdstill mention aproductbump. They are service specs, so I did not touch them here.Validation
python scripts/release-intent/validate_pr.py --description-file <example> --skip-owned-files-checkon each example block: exit 1 with the error above before this change, exit 0 after it.node scripts/spdx-headers.mjs: 1024 checked, 0 missing.git diff --check: clean.Risk
Documentation only. No code, build, or version file changes.
Checklist
git commit -s), certifying the Developer Certificate of Origin.validate_pr.pyruns on both examples.services/versions.jsonis written by automation — do not edit it by hand.