Skip to content

[None][chore] Waive failing torch-compile test#16461

Merged
brb-nv merged 1 commit into
NVIDIA:mainfrom
brb-nv:user/brb/waive-torch-compile-tests
Jul 16, 2026
Merged

[None][chore] Waive failing torch-compile test#16461
brb-nv merged 1 commit into
NVIDIA:mainfrom
brb-nv:user/brb/waive-torch-compile-tests

Conversation

@brb-nv

@brb-nv brb-nv commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Description

Waive failing torch-compile test blocking pre-merge.

Test Coverage

N/A

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

  • Tests
    • Added an integration-test waiver for a specific DeepSeek V3 Lite FP8 multi-GPU configuration.
    • Linked the waiver to the relevant tracked issue for visibility.

Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a waiver entry for the four-GPU DeepSeek V3 Lite FP8 block-scales test under a specific configuration with sampler_async_worker=True, linked to nvbugs/6445456.

Changes

DeepSeek V3 Lite waiver

Layer / File(s) Summary
Add test configuration waiver
tests/integration/test_lists/waives.txt
Adds a skip entry for the specified TestDeepSeekV3Lite.test_fp8_block_scales_4gpus configuration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: yuxianq, emmaqiaoch, brnguyen2

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the change and follows the repository's required [None][type] summary format.
Description check ✅ Passed The description includes the required sections and clearly states the waiver purpose with test coverage noted as N/A.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
tests/integration/test_lists/waives.txt (1)

1-1: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add the required NVIDIA copyright header.

This modified file has no visible NVIDIA copyright header. Add the repository-standard comment header at the top using 2026 as the current year, keeping it comment-prefixed so the waiver parser remains unaffected.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/test_lists/waives.txt` at line 1, Add the
repository-standard NVIDIA copyright comment header at the beginning of
waives.txt, using 2026 as the current year. Keep the header fully
comment-prefixed and preserve the existing waiver entry unchanged so the waiver
parser continues to process it.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 1: Add the repository-standard NVIDIA copyright comment header at the
beginning of waives.txt, using 2026 as the current year. Keep the header fully
comment-prefixed and preserve the existing waiver entry unchanged so the waiver
parser continues to process it.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1ea7e4f1-6905-4953-a713-7878beffc038

📥 Commits

Reviewing files that changed from the base of the PR and between 47ded3f and 0b6fa92.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

@brb-nv

brb-nv commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Waive test blocking pre-merge"

@brb-nv
brb-nv enabled auto-merge (squash) July 16, 2026 00:02
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59553 [ skip ] triggered by Bot. Commit: 0b6fa92 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59553 [ skip ] completed with state SUCCESS. Commit: 0b6fa92
Skipping testing for commit 0b6fa92

Link to invocation

@brb-nv
brb-nv merged commit 02c2c01 into NVIDIA:main Jul 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants