[None][chore] Waive failing torch-compile test#16461
Conversation
Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
📝 WalkthroughWalkthroughAdds a waiver entry for the four-GPU DeepSeek V3 Lite FP8 block-scales test under a specific configuration with ChangesDeepSeek V3 Lite waiver
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/test_lists/waives.txt (1)
1-1: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winAdd the required NVIDIA copyright header.
This modified file has no visible NVIDIA copyright header. Add the repository-standard comment header at the top using 2026 as the current year, keeping it comment-prefixed so the waiver parser remains unaffected.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` at line 1, Add the repository-standard NVIDIA copyright comment header at the beginning of waives.txt, using 2026 as the current year. Keep the header fully comment-prefixed and preserve the existing waiver entry unchanged so the waiver parser continues to process it.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 1: Add the repository-standard NVIDIA copyright comment header at the
beginning of waives.txt, using 2026 as the current year. Keep the header fully
comment-prefixed and preserve the existing waiver entry unchanged so the waiver
parser continues to process it.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1ea7e4f1-6905-4953-a713-7878beffc038
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
/bot skip --comment "Waive test blocking pre-merge" |
|
PR_Github #59553 [ skip ] triggered by Bot. Commit: |
|
PR_Github #59553 [ skip ] completed with state |
Description
Waive failing torch-compile test blocking pre-merge.
Test Coverage
N/A
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Summary by CodeRabbit