[https://nvbugs/6448152][perf] diagnose 2x admission with PP consensus#16518
Draft
chienchunhung wants to merge 5 commits into
Draft
[https://nvbugs/6448152][perf] diagnose 2x admission with PP consensus#16518chienchunhung wants to merge 5 commits into
chienchunhung wants to merge 5 commits into
Conversation
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Collaborator
Author
|
/bot run --disable-fail-fast --stage-list "GB300-12_GPUs-3_Nodes-PyTorch-Disagg-PerfSanity-CTX1-NODE1-GPU4-GEN1-NODE2-GPU8-Post-Merge-1" |
Collaborator
|
PR_Github #59814 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #59814 [ run ] completed with state
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
DIAGNOSTIC ONLY — DO NOT MERGE.
Question
Does the conservative generation-side KV-transfer admission budget cause the GB300 DeepSeek-R1 throughput regression, and does PP context-transfer consensus become material after that budget is relaxed?
This is the 2× admission / PP consensus enabled arm. The matched no-consensus arm is #16517.
Controlled change
Start from the exact tested [https://nvbugs/6448152][perf] diagnose PP consensus traffic #16487 head (
1522ea7230).Keep
max_tokens_in_buffer: 131104; physical C++/NIXL transfer-buffer allocation is unchanged.Apply a diagnostic-only multiplier to PyExecutor's logical admission budget:
2 * ceil(max_tokens_in_buffer / tokens_per_block)Remove only
TRTLLM_DIAGNOSTIC_DISABLE_PP_CONTEXT_CONSENSUS_TRAFFIC=1; the [https://nvbugs/6448152][perf] publish PP transfer status from workers #16386 worker-published PP consensus path remains active.Leave the diagnostic multiplier default at
1; only the exact GB300 perf-sanity YAML sets it to2.For this FlashMLA workload, the expected base budget is 2,049 blocks. A 131,072-token request costs 2,048 blocks, so the effective 4,098-block budget admits two full transfers (4,096 blocks) without resizing the transport buffer.
The run must contain both markers:
It should also log activation of worker-published context-transfer consensus and must not log the no-consensus completion marker.
Experiment matrix
The two 2× arms share the same code and differ only by the no-consensus environment flag. If their results are unexpectedly close to a threshold, rerun a same-harness 1× control to remove the negligible fast-return diagnostic method-call delta from the historical controls.
flowchart LR A["#16487 tested anchor<br/>1× / consensus off"] --> H["common logical 2× admission harness"] H --> OFF["#16517<br/>2× / consensus off"] H --> ON["#16518<br/>2× / consensus on"]Interpretation
Validation
transformersand the compiled TRT-LLM runtime; CI owns runtime validation.Target CI
Run only:
GB300-12_GPUs-3_Nodes-PyTorch-Disagg-PerfSanity-CTX1-NODE1-GPU4-GEN1-NODE2-GPU8-Post-Merge-1Compare output-token throughput with 798.58 (#16487) and 1562.83 baseline.