Skip to content

[https://nvbugs/6442074][fix] Unbreak main: DSparkWorker forward rename + test stub _forward_impl #16579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chzblych merged 2 commits into from
Jul 20, 2026
Merged

[https://nvbugs/6442074][fix] Unbreak main: DSparkWorker forward rename + test stub _forward_impl #16579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
791901f
[https://nvbugs/6442074][fix] DSparkWorker: rename forward to _forwar…
brnguyen2 Jul 19, 2026
0dbe52f
[https://nvbugs/6442074][fix] Give the rejection-buffers-guard test s…
dongfengy Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tensorrt_llm/_torch/speculative/dspark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ def _draft_gen_block_batched(
)
return block_logits

def forward(
def _forward_impl(
self,
input_ids,
position_ids,
Expand Down
3 changes: 3 additions & 0 deletions tests/unittest/_torch/speculative/test_rejection_buffers_guard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,9 @@ class _Worker(SpecWorkerBase):
def max_draft_len(self) -> int:
return K

def _forward_impl(self, *args: object, **kwargs: object) -> None:
raise NotImplementedError


def _dispatch_meta(**over):
base = dict(
Expand Down
Loading