[TRTQA-3273][test] Waive 4 failed cases for main in QA CI - #16584
Conversation
Bug(s): 6473161 Requested by: qa@nvidia.com Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
/bot skip --comment "skip test on L40S only" |
📝 WalkthroughWalkthroughAdds four L40S waiver entries for Llama 3.1 8B instruct FP8 accuracy tests, covering single- and four-GPU variants with both ChangesL40S FP8 test waivers
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
288-291: 📐 Maintainability & Code Quality | 🔵 TrivialWaiver coverage is sufficient for the stated scope.
The four entries cover both test variants, both
fp8kvvalues, and the single-/four-GPU cases. No additional test-list file is needed; remove these waivers in a follow-up once NVBug 6473161 is fixed.As per path instructions, coverage for this waiver change is sufficient, with restoration tracked outside this PR.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` around lines 288 - 291, Keep the four NVBug 6473161 waivers in the existing test list unchanged, covering both fp8 test variants, both fp8kv values, and single-/four-GPU cases. Do not add another test-list file; restoration should occur separately after the underlying issue is fixed.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 288-291: Add the repository-standard NVIDIA copyright header with
the current year at the beginning of the modified waiver list in waives.txt,
before the existing waiver entries; leave the entries unchanged.
---
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 288-291: Keep the four NVBug 6473161 waivers in the existing test
list unchanged, covering both fp8 test variants, both fp8kv values, and
single-/four-GPU cases. Do not add another test-list file; restoration should
occur separately after the underlying issue is fixed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6b185a89-52c7-4c72-bd95-ac4c8ff8d7e8
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #60223 [ skip ] triggered by Bot. Commit: |
|
PR_Github #60223 [ skip ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by qa@nvidia.com)
Target branch:
mainBug(s): 6473161
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit