[TRTQA-3282][test] Waive 3 failed cases for main in QA CI#16600
Conversation
Bug(s): 6327718, 6473397, 6479324 Requested by: qa@nvidia.com Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
/bot skip --comment "waive test on H100 only" |
📝 WalkthroughWalkthroughThe integration waiver list adds four H100 ChangesH100 Integration Waivers
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/test_lists/waives.txt (1)
245-257: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winAdd the NVIDIA copyright header required for modified files.
This modified file has no visible NVIDIA copyright header or year. Add the repository-standard header at the top; comment lines are ignored by the waiver parser.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` around lines 245 - 257, Prepend the repository-standard NVIDIA copyright header, including the appropriate year, to the modified waives.txt file. Keep the existing waiver entries unchanged; the header’s comment lines will be ignored by the parser.Source: Coding guidelines
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
245-257: 🩺 Stability & Availability | 🔵 TrivialTrack QA follow-up outside this waiver PR.
Coverage is intentionally insufficient while these cases are skipped. Keep root-cause fixes tracked for
accuracy/test_epd_disagg_multimodal.py,accuracy/test_llm_api_pytorch.py, anddisaggregated/test_disaggregated.pyagainst the linked bugs.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` around lines 245 - 257, Track QA follow-up separately from this waiver update: retain the listed skips and linked bug references, while ensuring root-cause fixes remain tracked for the affected accuracy tests in test_epd_disagg_multimodal.py and test_llm_api_pytorch.py, plus the disaggregated tests in test_disaggregated.py.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 245: Remove the duplicate H100 VideoMMEEPD waiver entry from the waiver
list, or replace it with the intended unscoped entry if the waiver must apply
only to H100; ensure the processed waiver set does not contain redundant entries
and retains the Bug 6327718 association.
---
Outside diff comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 245-257: Prepend the repository-standard NVIDIA copyright header,
including the appropriate year, to the modified waives.txt file. Keep the
existing waiver entries unchanged; the header’s comment lines will be ignored by
the parser.
---
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 245-257: Track QA follow-up separately from this waiver update:
retain the listed skips and linked bug references, while ensuring root-cause
fixes remain tracked for the affected accuracy tests in
test_epd_disagg_multimodal.py and test_llm_api_pytorch.py, plus the
disaggregated tests in test_disaggregated.py.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 89e5fec0-e388-451a-857a-e3c428d6cc8d
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #60291 [ skip ] triggered by Bot. Commit: |
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
|
PR_Github #60291 [ skip ] completed with state |
|
/bot skip --comment "waive test on H100 only" |
|
PR_Github #60308 [ skip ] triggered by Bot. Commit: |
|
PR_Github #60308 [ skip ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by qa@nvidia.com)
Target branch:
mainBug(s): 6327718, 6473397, 6479324
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit