[TRTQA-3277][test] Waive 7 failed cases for main in QA CI#16605
Conversation
Bug(s): 6474888, 6474892, 6474894, 6475346, 6475622 Requested by: qa@nvidia.com Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
/bot skip --comment "waive tests on B300" |
📝 WalkthroughWalkthroughThe B300 integration-test waiver list adds skip entries for three VideoMMEEPD multimodal variants and four additional model or auto-scaling configurations, each retaining associated NV bug references. ChangesB300 integration test waivers
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
199-201: 🗄️ Data Integrity & Integration | 🔵 TrivialRun the existing waiver-list validation before merge.
No new test file is needed for this waiver-only change; coverage is a validation follow-up outside this PR. Run
scripts/check_test_list.pywith--qaand--l0, and confirm all seven new B300 entries resolve againstqa_test.txt/l0_test.txtand pytest collection succeeds. As per path instructions fortests/**, report whether coverage is sufficient or requires follow-up outside this PR.Also applies to: 210-211, 217-217, 220-220
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` around lines 199 - 201, Run the existing waiver-list validation using scripts/check_test_list.py with both QA and L0 validation enabled, then confirm all seven new B300 entries resolve against qa_test.txt and l0_test.txt and that pytest collection succeeds. Report whether coverage is sufficient; if not, record the required follow-up outside this PR.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 199-201: Add the repository-standard NVIDIA copyright header at
the beginning of tests/integration/test_lists/waives.txt, updating the copyright
year as required while preserving the existing waiver entries unchanged.
---
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 199-201: Run the existing waiver-list validation using
scripts/check_test_list.py with both QA and L0 validation enabled, then confirm
all seven new B300 entries resolve against qa_test.txt and l0_test.txt and that
pytest collection succeeds. Report whether coverage is sufficient; if not,
record the required follow-up outside this PR.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6287780d-4374-4499-9a1c-bdec81a31ab6
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #60302 [ skip ] triggered by Bot. Commit: |
|
PR_Github #60302 [ skip ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by qa@nvidia.com)
Target branch:
mainBug(s): 6474888, 6474892, 6474894, 6475346, 6475622
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit