Skip to content

[None][test] Waive hang issues#16625

Merged
xinhe-nv merged 3 commits into
NVIDIA:mainfrom
xinhe-nv:waive
Jul 21, 2026
Merged

[None][test] Waive hang issues#16625
xinhe-nv merged 3 commits into
NVIDIA:mainfrom
xinhe-nv:waive

Conversation

@xinhe-nv

@xinhe-nv xinhe-nv commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Added an integration-test waiver for a known issue affecting DeepSeek V3 Lite disaggregated serving.
    • The affected test is now skipped and linked to the relevant issue for tracking.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@xinhe-nv
xinhe-nv marked this pull request as ready for review July 20, 2026 12:07
@xinhe-nv
xinhe-nv requested review from a team as code owners July 20, 2026 12:07
@xinhe-nv
xinhe-nv enabled auto-merge (squash) July 20, 2026 12:07
@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "waive test only"

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0faf2654-91ca-4dad-b4b3-83f420548ff0

📥 Commits

Reviewing files that changed from the base of the PR and between 5d8a786 and aa6ed56.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A new SKIP waiver is added for the DeepSeekV3Lite disaggregated serving test case test_gen_first[noadp-mtp0], linked to nvbugs/6481375.

Changes

Integration test waiver

Layer / File(s) Summary
Add DeepSeekV3Lite waiver
tests/integration/test_lists/waives.txt
Adds a SKIP entry for the specified test case and associates it with nvbugs/6481375.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: bowenfu, mzweilz

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is mostly the template with no actual issue, solution, or test coverage details filled in. Replace the template text with a short Description and Test Coverage section that explain the waiver and relevant validation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and clearly describes the test waiver for hang issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60364 [ skip ] triggered by Bot. Commit: aa6ed56 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60364 [ skip ] completed with state SUCCESS. Commit: aa6ed56
Skipping testing for commit aa6ed56

Link to invocation

…est_gen_first[noadp-mtp0]

Skip accuracy/test_disaggregated_serving.py::TestDeepSeekV3Lite::test_gen_first[noadp-mtp0] due to nvbugs/6481375.

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "waive test only"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60538 [ skip ] triggered by Bot. Commit: 82d80a0 Link to invocation

@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "waive test only"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60543 [ skip ] triggered by Bot. Commit: 95c42d2 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60538 [ skip ] completed with state ABORTED. Commit: 82d80a0

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60543 [ skip ] completed with state SUCCESS. Commit: 95c42d2
Skipping testing for commit 95c42d2

Link to invocation

@xinhe-nv
xinhe-nv merged commit c67d098 into NVIDIA:main Jul 21, 2026
7 checks passed
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60544 [ ] completed with state FAILURE. Commit: 95c42d2
Not allowed on merged PR

Link to invocation

@xinhe-nv
xinhe-nv deleted the waive branch July 21, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants