[None][infra] Waive 1 failed cases for main in pre-merge 49032#16684
[None][infra] Waive 1 failed cases for main in pre-merge 49032#16684trtllm-agent wants to merge 1 commit into
Conversation
Bug(s): 6488811 Requested by: @dpitman-nvda Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
/bot skip --comment "Waive only" |
WalkthroughAdds a skipped integration-test waiver for ChangesLLM API test waiver
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 434: Add the repository-standard NVIDIA copyright header to the modified
waives.txt file using parser-safe comment syntax, and set the copyright year to
2026; preserve the existing test entry unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 16f84a9f-b13b-43ef-8f77-ddfdd72df96c
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
| unittest/llmapi/test_llm_pytorch.py::test_gqa_nemo_lora[None] SKIP (https://nvbugs/6162504) | ||
| unittest/llmapi/test_llm_pytorch.py::test_gqa_nemo_lora[cuda_graph_config0] SKIP (https://nvbugs/6162504) | ||
| unittest/llmapi/test_llm_pytorch.py::test_llm_context_only_timed_out[None] SKIP (https://nvbugs/6484986) | ||
| unittest/llmapi/test_llm_pytorch.py::test_llm_context_only_timed_out_kv_cache_exhausted[None-UCX-100] SKIP (https://nvbugs/6488811) |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add the required NVIDIA copyright header/year update.
This modified file has no visible NVIDIA copyright header. Add the repository-standard header as parser-safe comments and update its copyright year to 2026.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@tests/integration/test_lists/waives.txt` at line 434, Add the
repository-standard NVIDIA copyright header to the modified waives.txt file
using parser-safe comment syntax, and set the copyright year to 2026; preserve
the existing test entry unchanged.
Source: Coding guidelines
| @@ -431,6 +431,7 @@ unittest/llmapi/test_llm_multi_gpu_pytorch.py::test_tinyllama_logits_processor_t | |||
| unittest/llmapi/test_llm_pytorch.py::test_gqa_nemo_lora[None] SKIP (https://nvbugs/6162504) | |||
👎 Promotion blocked, new vulnerability foundVulnerability report
|
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @dpitman-nvda)
Target branch:
mainBug(s): 6488811
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Dev Engineer Review
None-UCX-100parameter.6488811and marks the test as skipped.QA Engineer Review
tests/integration/test_lists/waives.txtby adding one waived test entry; no entries were removed.