Skip to content

[None][infra] Waive 1 failed cases for main in pre-merge 49032#16684

Closed
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260721-193224
Closed

[None][infra] Waive 1 failed cases for main in pre-merge 49032#16684
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260721-193224

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @dpitman-nvda)
Target branch: main
Bug(s): 6488811

Waive entries added

unittest/llmapi/test_llm_pytorch.py::test_llm_context_only_timed_out_kv_cache_exhausted[None-UCX-100] SKIP (https://nvbugs/6488811)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

  • Added a correctly formatted waiver for the timed-out KV-cache exhaustion test with the None-UCX-100 parameter.
  • References bug 6488811 and marks the test as skipped.
  • No duplicate waiver entries or unintended API/code changes found.

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt by adding one waived test entry; no entries were removed.
  • CBTS coverage data is unavailable, so the verdict is needs follow-up.

Bug(s): 6488811
Requested by: @dpitman-nvda

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@dpitman-nvda

Copy link
Copy Markdown
Collaborator

/bot skip --comment "Waive only"

@tburt-nv tburt-nv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already have a PR open for this one: #16682

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Adds a skipped integration-test waiver for test_llm_context_only_timed_out_kv_cache_exhausted with the None-UCX-100 parameter and nvbugs reference 6488811.

Changes

LLM API test waiver

Layer / File(s) Summary
Add parameterized test waiver
tests/integration/test_lists/waives.txt
Adds a skipped waiver entry for the timed-out KV-cache exhaustion test with parameter None-UCX-100 and reference https://nvbugs/6488811.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: schetlur-nv, brnguyen2

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the auto-generated waiver change and uses the expected [None][infra] format.
Description check ✅ Passed It explains the waiver, linked bug, and affected test, but omits the template's Test Coverage and PR Checklist sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 434: Add the repository-standard NVIDIA copyright header to the modified
waives.txt file using parser-safe comment syntax, and set the copyright year to
2026; preserve the existing test entry unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 16f84a9f-b13b-43ef-8f77-ddfdd72df96c

📥 Commits

Reviewing files that changed from the base of the PR and between a75e333 and dde7148.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

unittest/llmapi/test_llm_pytorch.py::test_gqa_nemo_lora[None] SKIP (https://nvbugs/6162504)
unittest/llmapi/test_llm_pytorch.py::test_gqa_nemo_lora[cuda_graph_config0] SKIP (https://nvbugs/6162504)
unittest/llmapi/test_llm_pytorch.py::test_llm_context_only_timed_out[None] SKIP (https://nvbugs/6484986)
unittest/llmapi/test_llm_pytorch.py::test_llm_context_only_timed_out_kv_cache_exhausted[None-UCX-100] SKIP (https://nvbugs/6488811)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add the required NVIDIA copyright header/year update.

This modified file has no visible NVIDIA copyright header. Add the repository-standard header as parser-safe comments and update its copyright year to 2026.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/test_lists/waives.txt` at line 434, Add the
repository-standard NVIDIA copyright header to the modified waives.txt file
using parser-safe comment syntax, and set the copyright year to 2026; preserve
the existing test entry unchanged.

Source: Coding guidelines

@@ -431,6 +431,7 @@ unittest/llmapi/test_llm_multi_gpu_pytorch.py::test_tinyllama_logits_processor_t
unittest/llmapi/test_llm_pytorch.py::test_gqa_nemo_lora[None] SKIP (https://nvbugs/6162504)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thread for #16684 (review)

@github-actions

Copy link
Copy Markdown

👎 Promotion blocked, new vulnerability found

Vulnerability report

Component Vulnerability Description Severity
pytorch CVE-2025-3000 A vulnerability classified as critical has been found in PyTorch 2.6.0. This affects the function torch.jit.script. The manipulation leads to memory corruption. It is possible to launch the attack on the local host. The exploit has been disclosed to the public and may be used. MEDIUM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants