Skip to content

[None][fix] Drop stale benchmarks copies from Dockerfile.multi - #16884

Merged
jieli-matrix merged 1 commit into
NVIDIA:mainfrom
jieli-matrix:fix/dockerfile-multi-drop-stale-benchmarks-copy
Jul 27, 2026
Merged

[None][fix] Drop stale benchmarks copies from Dockerfile.multi#16884
jieli-matrix merged 1 commit into
NVIDIA:mainfrom
jieli-matrix:fix/dockerfile-multi-drop-stale-benchmarks-copy

Conversation

@jieli-matrix

@jieli-matrix jieli-matrix commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Description

docker/Dockerfile.multi still copies the benchmarks/ directory, which was
deleted from the repository by #16612
([TRTLLM-14474][chore] Remove legacy python relics and refresh docs after the
backend removal, commit 3c07ada3c5). That PR did not update the Dockerfile, so
every build of the wheel or release target on main has been broken since
Jul 24
:

Dockerfile.multi:109
 107 |     FROM ${DEVEL_IMAGE} AS wheel
 108 |     WORKDIR /src/tensorrt_llm
 109 | >>> COPY benchmarks benchmarks
ERROR: failed to solve: failed to compute cache key: "/benchmarks": not found

Why CI did not catch this

Pre-merge CI builds the wheel inside an already-built devel container
(buildWheelInContainer in jenkins/Build.groovy) rather than going through the
wheel/release stages of Dockerfile.multi, so it never evaluates the failing
COPY. The breakage only surfaces on paths that build the release image from the
Dockerfile, e.g. make -C docker release_build

Dev Engineer Review

  • Removed stale benchmarks/ references from wheel and release stages in docker/Dockerfile.multi (no remaining benchmarks references in the current Dockerfile).
  • Prevents Docker builds from failing after the benchmarks/ directory deletion.
  • Changes are scoped to Docker image assembly and do not introduce API/runtime behavior changes.

QA Engineer Review

No test changes.

@jieli-matrix
jieli-matrix requested a review from a team as a code owner July 27, 2026 03:39
@jieli-matrix
jieli-matrix requested a review from Wanli-Jiang July 27, 2026 03:40
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9d96d28d-f559-40aa-a63f-1e6d1e83c8d6

📥 Commits

Reviewing files that changed from the base of the PR and between 7d03ebd and feb6a19.

📒 Files selected for processing (1)
  • docker/Dockerfile.multi
💤 Files with no reviewable changes (1)
  • docker/Dockerfile.multi

Walkthrough

The multi-stage Docker build no longer copies the benchmarks directory into the wheel-stage context or final release image. Other context files, built wheels, library symlink setup, and runtime cleanup remain unchanged.

Changes

Release image assembly

Layer / File(s) Summary
Exclude benchmark artifacts
docker/Dockerfile.multi
The wheel stage no longer copies benchmarks, and the release stage removes its benchmark bind mount and copy while retaining the other context and wheel transfers.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: wanli-jiang, tburt-nv, yiqingy0

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the change: removing stale benchmarks copies from Dockerfile.multi.
Description check ✅ Passed The description clearly explains the bug and fix, but it omits the Test Coverage and PR Checklist sections from the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jieli-matrix jieli-matrix changed the title [Infra][fix] Drop stale benchmarks copies from Dockerfile.multi [None][fix] Drop stale benchmarks copies from Dockerfile.multi Jul 27, 2026

@ZhanruiSunCh ZhanruiSunCh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jieli-matrix

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61802 [ run ] triggered by Bot. Commit: 7d03ebd Link to invocation

The benchmarks/ directory was removed from the repository in NVIDIA#16612, but
Dockerfile.multi still copied it, so every build of the wheel/release
target fails with:

  Dockerfile.multi:109
  >>> COPY benchmarks benchmarks
  ERROR: failed to solve: failed to compute cache key: "/benchmarks": not found

Remove the wheel-stage COPY along with the now-dangling bind mount and
copy of /mnt/benchmarks in the release stage.

Signed-off-by: Jie Li <lijie@nvidia.com>
@jieli-matrix
jieli-matrix force-pushed the fix/dockerfile-multi-drop-stale-benchmarks-copy branch from 7d03ebd to feb6a19 Compare July 27, 2026 05:07
@jieli-matrix
jieli-matrix enabled auto-merge (squash) July 27, 2026 05:07
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61802 [ run ] completed with state FAILURE. Commit: 7d03ebd
/LLM/main/L0_MergeRequest_PR pipeline #50001 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@ZhanruiSunCh

Copy link
Copy Markdown
Collaborator

/bot skip --comment "Benchmarks issue fixed, the pipeline is failed due to a known network flaky issue."

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61938 [ skip ] triggered by Bot. Commit: feb6a19 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61938 [ skip ] completed with state SUCCESS. Commit: feb6a19
Skipping testing for commit feb6a19

Link to invocation

@jieli-matrix
jieli-matrix merged commit e95cb90 into NVIDIA:main Jul 27, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants