[None][fix] Drop stale benchmarks copies from Dockerfile.multi - #16884
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe multi-stage Docker build no longer copies the ChangesRelease image assembly
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --stage-list "Build-Docker-Images" |
|
PR_Github #61802 [ run ] triggered by Bot. Commit: |
The benchmarks/ directory was removed from the repository in NVIDIA#16612, but Dockerfile.multi still copied it, so every build of the wheel/release target fails with: Dockerfile.multi:109 >>> COPY benchmarks benchmarks ERROR: failed to solve: failed to compute cache key: "/benchmarks": not found Remove the wheel-stage COPY along with the now-dangling bind mount and copy of /mnt/benchmarks in the release stage. Signed-off-by: Jie Li <lijie@nvidia.com>
7d03ebd to
feb6a19
Compare
|
PR_Github #61802 [ run ] completed with state
|
|
/bot skip --comment "Benchmarks issue fixed, the pipeline is failed due to a known network flaky issue." |
|
PR_Github #61938 [ skip ] triggered by Bot. Commit: |
|
PR_Github #61938 [ skip ] completed with state |
Description
docker/Dockerfile.multistill copies thebenchmarks/directory, which wasdeleted from the repository by #16612
([TRTLLM-14474][chore] Remove legacy python relics and refresh docs after the
backend removal, commit
3c07ada3c5). That PR did not update the Dockerfile, soevery build of the
wheelorreleasetarget onmainhas been broken sinceJul 24:
Why CI did not catch this
Pre-merge CI builds the wheel inside an already-built devel container
(
buildWheelInContainerinjenkins/Build.groovy) rather than going through thewheel/releasestages ofDockerfile.multi, so it never evaluates the failingCOPY. The breakage only surfaces on paths that build the release image from theDockerfile, e.g.
make -C docker release_buildDev Engineer Review
benchmarks/references fromwheelandreleasestages indocker/Dockerfile.multi(no remainingbenchmarksreferences in the current Dockerfile).benchmarks/directory deletion.QA Engineer Review
No test changes.