Add additional warning flags for dev builds not enabled by Wall or Wextra#8283
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
|
/ok to test |
1 similar comment
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Jacobfaib
force-pushed
the
jacobf/2026-04-02/clang-more-warnings
branch
from
e6b2b8c to
d8e2e14
Compare
| #elif _CCCL_HAS_CPP_ATTRIBUTE(assume) && (_CCCL_STD_VER >= 2023) | ||
| # define _CCCL_ASSUME(...) [[assume(__VA_ARGS__)]] |
There was a problem hiding this comment.
Q: Why shouldn't we use the attribute if the compiler supports it before C++23?
There was a problem hiding this comment.
clang warns with -Wc++23-compat. I consider this a bug, TBH, that it allows you to use [[assume]] but tells you off for doing so.
There was a problem hiding this comment.
Do we care about the -Wc++23-compat warning?
There was a problem hiding this comment.
Until we start comprehensively testing C++23, I think we should heed the warning. Our CI matrix only goes to C++20 for now.
Note this warning actually only fired due to a previous version of this PR where I also had -pedantic enabled, but that resulted in so many warnings that I turned it off and hope that someone else eventually becomes motivated enough to fix that :)
Jacobfaib
force-pushed
the
jacobf/2026-04-02/clang-more-warnings
branch
from
6b62c48 to
df7db2d
Compare
🥳 CI Workflow Results🟩 Finished in 1h 49m: Pass: 100%/478 | Total: 5d 04h | Max: 1h 49m | Hits: 98%/555480See results here. |
2 participants
Description
This crucially also adds
-ftemplate-backtrace-limit=0, so CI no longer truncates template expansions in error logs.-fmacro-backtrace-limit=0, similarly but for macro expansions.Checklist