Add shellcheck to pre-commit and devcontainers#8287
Open
trxcllnt wants to merge 3 commits intoNVIDIA:mainfrom
Open
Add shellcheck to pre-commit and devcontainers#8287trxcllnt wants to merge 3 commits intoNVIDIA:mainfrom
trxcllnt wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
trxcllnt
commented
Apr 3, 2026
trxcllnt
force-pushed
the
fea/shellcheck
branch
10 times, most recently
from
f6d102a to
5984ab9
Compare
trxcllnt
force-pushed
the
fea/shellcheck
branch
2 times, most recently
from
7fd047a to
5987dcf
Compare
Jacobfaib
approved these changes
Apr 3, 2026
Contributor
Jacobfaib
left a comment
Jacobfaib
left a comment
There was a problem hiding this comment.
LGTM modulo minor fixups
trxcllnt
force-pushed
the
fea/shellcheck
branch
2 times, most recently
from
f2a0cf8 to
bd3dbac
Compare
trxcllnt
force-pushed
the
fea/shellcheck
branch
6 times, most recently
from
17f9bb3 to
cb3dd42
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 6h 43m: Pass: 100%/478 | Total: 3d 06h | Max: 1h 30m | Hits: 99%/555170See results here. |
gonidelis
reviewed
Apr 6, 2026
| - id: shellcheck | ||
| exclude: | | ||
| (?x)^( | ||
| ^.*libcudacxx/cmake/config\.guess$ |
Member
There was a problem hiding this comment.
why do we exclude this specific cmake facility? in case shellcheck confused it as shell script we can add a comment about it still
Contributor
There was a problem hiding this comment.
Shellcheck recognizes it as a shell script (from the shebang), but it's vendored so we shouldn't touch it.
alliepiper
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly the same as #8173, but with SC2250 disabled to reduce noise for comparison.