Strip debug symbols from cuda-core Linux wheels#1883
Open
leofang wants to merge 1 commit intoNVIDIA:mainfrom
Open
Strip debug symbols from cuda-core Linux wheels#1883leofang wants to merge 1 commit intoNVIDIA:mainfrom
leofang wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Add -Wl,--strip-all to extra_link_args for wheel builds on Linux, matching the existing behavior in cuda_bindings/build_hooks.py. Without stripping, the 0.7.0 Linux wheel is ~30 MB (103 MB extracted) because every .so ships with debug_info. After stripping, extracted size drops from 103 MB to ~11 MB, bringing the wheel in line with the ~4-5 MB Windows wheels. Closes NVIDIA#1881 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
mdboom
requested changes
Apr 8, 2026
|
|
||
| def build_editable(wheel_directory, config_settings=None, metadata_directory=None): | ||
| _build_cuda_core() | ||
| _build_cuda_core(strip=False) |
Contributor
There was a problem hiding this comment.
Shouldn't this be passing strip=True?
Contributor
There was a problem hiding this comment.
My bad -- this is the editable one.
I find it usual that editable installs are implicitly different. Other build systems I've seen would just have a --debug flag to indicate building an unstripped, debuggable binary. I don't think we should piggyback on editable for debuggable (though I realize cuda_bindings already does that).
|
|
||
| def build_wheel(wheel_directory, config_settings=None, metadata_directory=None): | ||
| _build_cuda_core() | ||
| _build_cuda_core(strip=True) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Wl,--strip-alltoextra_link_argsfor wheel builds on Linux incuda_core/build_hooks.py, matching the existing behavior incuda_bindings/build_hooks.py.soships withdebug_info. After stripping, extracted size drops from 103 MB to ~11 MB, bringing the wheel in line with the ~4-5 MB Windows wheels.Closes #1881
Test plan
pip wheel .incuda_core/and verify.sofiles are stripped (file *.soshould NOT showwith debug_info, not stripped)strip=Falsepath)-- Leo's bot