Skip non-regular files in tryResolveLibrary#108
Open
arcusbuilds wants to merge 1 commit into
Open
Conversation
tryResolveLibrary validated candidates with filepath.EvalSymlinks, which succeeds for any existing path, including directories. Since candidates are returned on first match and /usr/lib64 is searched before /usr/lib/x86_64-linux-gnu, a stray directory named after the library in /usr/lib64 shadows the real library in a later search path and the resolved path fails to dlopen. Skip any candidate that does not resolve to a regular file so resolution continues through the remaining search paths, falling back to returning the library name as is. Signed-off-by: Srijan Keshri <srijan.keshri007@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tryResolveLibraryreturns the first candidate thatfilepath.EvalSymlinksresolves.EvalSymlinkssucceeds for anything that exists, directories included, so a stray directory named after the library in an early search path (for example an empty/usr/lib64/libnvidia-ml.so.1on an Ubuntu host) shadows the real library in a later one, and the dlopen that follows fails.With this change, resolution skips any candidate that does not resolve to a regular file and keeps searching, falling back to the documented behavior of returning the library name as is.
The added test covers the shadowing scenario plus the happy path and the fallback paths. The shadowing and directories-only cases fail without the fix.
This is the same bug fixed in kubernetes-sigs/dra-driver-nvidia-gpu#1275, which carries a copy of this discovery code.
Fixes #107