Skip to content

add finalizer directly to the GPUCluster manifest #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tariq1890 wants to merge 1 commit into from
+6 −1
Closed

add finalizer directly to the GPUCluster manifest #2673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,10 @@ metadata:
"apiVersion": "nvidia.com/v1alpha1",
"kind": "GPUCluster",
"metadata": {
"name": "gpu-cluster"
"name": "gpu-cluster",
"finalizers": [
"gpucluster.nvidia.com/dra-resourceclaim"

@rajathagasthya rajathagasthya Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is somewhat of a behavior change. We're pre-adding the finalizer instead of adding it after the operator's first reconcile. If the operator never comes up during helm install, you cannot delete this CR without manually removing the finalizer. I'd rather have one way to add and remove the finalizer. Not a strong opinion, but I'm not entirely sure this change is worth it.

This also means we need to maintain this finalizer in multiple places instead of a single constant in the controller.

]
},
"spec": {
"draDriver": {
Expand Down
2 changes: 2 additions & 0 deletions deployments/gpu-operator/templates/gpucluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ metadata:
# keep helm from also deleting it.
annotations:
"helm.sh/resource-policy": keep
finalizers:
- gpucluster.nvidia.com/dra-resourceclaim
spec:
draDriver:
{{- if .Values.draDriver.repository }}
Expand Down
Loading