Skip to content

fix(machine-controller): close rack firmware test transaction #5042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chet merged 1 commit into from
Aug 17, 2026
+8 −4
Merged

fix(machine-controller): close rack firmware test transaction #5042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions crates/machine-controller/tests/integration/rack_firmware_upgrade.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,9 @@ async fn advances_on_completion(pool: PgPool) {
}

#[sqlx_test]
async fn assigned_host_returns_to_assigned_ready_on_completion(pool: PgPool) {
async fn assigned_host_returns_to_assigned_ready_on_completion(
pool: PgPool,
) -> Result<(), Box<dyn std::error::Error>> {
let mut env = Env::builder(pool).build().await;
let host = managed_host(&env.test_harness).await;
let instance_id = create_instance(&env.test_harness, &host).await;
Expand Down Expand Up @@ -223,10 +225,12 @@ async fn assigned_host_returns_to_assigned_ready_on_completion(pool: PgPool) {
assert!(machine.host_reprovision_requested.is_none());

let mut txn = env.test_harness.db_txn().await;
let attached_instance = db::instance::find_id_by_machine_id(txn.as_mut(), &host.host.id)
.await
.unwrap();
let attached_instance =
db::instance::find_id_by_machine_id(txn.as_mut(), &host.host.id).await?;
assert_eq!(attached_instance, Some(instance_id));
txn.rollback().await?;

Ok(())
}

#[sqlx_test]
Expand Down
Loading