Make GPU Feature Discovery more robust to device failures - #1561
Closed
elezar wants to merge 6 commits into
Closed
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
skip-errors-in-gfd
branch
from
December 10, 2025 12:59
2d29a51 to
04b8a45
Compare
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
skip-errors-in-gfd
branch
from
December 10, 2025 14:16
04b8a45 to
74b7cb7
Compare
klueska
reviewed
Dec 12, 2025
| func newGFDRunner(cfg *Config, nvmllib nvml.Interface, vgpul vgpu.Interface, config *spec.Config) (*gfd, error) { | ||
| devicelib := device.New(nvmllib) | ||
| devicelib := device.New(nvmllib, | ||
| // TODO: Do we want to expose this as a config option? |
Contributor
There was a problem hiding this comment.
You mean as a flag / envvar to the CLI / in the config file?
Contributor
|
@elezar This PR needs to be rebased. And is it ready to move out from Draft state? |
Member
Author
|
Closing this. Feel free to reopen / restore if required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enumerating devices, a single device that has errors causes GFD to fail -- skipping any remaining devices. This manifests as errors similar to:
This change pulls in changes from
go-nvlib(vendored in locally) (see NVIDIA/go-nvlib#80), that allow errors in enumerating devices to be ignored and ensures that the device lib is constructed with the required option. A simple unit test demonstrates how these errors are handled to ensure that labels are still generated.