fix: mark all devices sharing a physical GPU unhealthy on Xid errors - #1930
Open
tryuuu wants to merge 1 commit into
Open
fix: mark all devices sharing a physical GPU unhealthy on Xid errors#1930tryuuu wants to merge 1 commit into
tryuuu wants to merge 1 commit into
Conversation
Signed-off-by: tryuuu <ryu23210@gmail.com>
Contributor
|
Thank you @tryuuu for your contribution. On an initial glance, this looks fine to me. Let me run some more tests against this branch and get back to you sometime next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1929
checkHealthkept only one*Deviceper physical GPU UUID inparentToDeviceMap, so devices sharing a physical GPU overwrote each other. As a result an Xid event marked at most one device as unhealthy. With replication (time slicing or MPS) the other replicas of the broken GPU stayed schedulable, and with MIG the event could even be dropped entirely because the targeted instance was never stored in the map.This PR changes the map to
map[string][]*Deviceand fans each Xid event out over all devices under the event UUID, so every affected device is reported as unhealthy.