net/ib: Print qp_num in completion error log#2220
Open
zrss wants to merge 1 commit into
Open
Conversation
Signed-off-by: zrss <huangzhesi@gmail.com>
Collaborator
|
@stephenmsachs @thomasgillis please take a look and mirror if this is good. |
Collaborator
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes
wc.qp_numin the detailed NET/IB completion error log.NCCL already prints
qp_numin the nearby CQE error log, but the detailed completion error line contains the peer, status, vendor error, local/remote GID, and HCA. Includingqp_numin that same detailed line makes RoCE failures such asIBV_WC_RETRY_EXC_ERR(12)easier to correlate with earlier QP creation/connect logs.Related Issues
Closes #2219
Changes & Impact
This is a logging-only change.
The detailed NET/IB completion error WARN now changes from:
to:
Performance Impact
No expected performance impact.