net_ib: free GIN barrier buffer on failure#2227
Open
wanglei875 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves error handling in the IB P2P barrier to correctly propagate failures and ensure allocated memory is released on error paths.
Changes:
- Switches
ncclGinIbP2PBarrierto useNCCLCHECKGOTOwith anoutcleanup label. - Ensures
dummyis initialized and freed in a shared cleanup path. - Returns the actual
ncclResult_tstatus instead of always returning success.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+168
to
+173
| int* dummy = nullptr; | ||
| NCCLCHECKGOTO(ncclIbMalloc((void**)&dummy, cComm->nranks * sizeof(int)), ret, out); | ||
| NCCLCHECKGOTO(ncclGinIbAllGather(cComm, dummy + cComm->rank, dummy, sizeof(int)), ret, out); | ||
| out: | ||
| if (dummy) free(dummy); | ||
| return ret; |
Signed-off-by: WangLei <1539790288@qq.com>
Collaborator
|
++ @jynv to mirror if reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ncclGinIbP2PBarrier allocates a temporary dummy buffer and then calls ncclGinIbAllGather. If the allgather fails, the existing NCCLCHECK path returns before freeing the buffer.
Use a local cleanup label so the dummy buffer is released on both success and failure paths.
Validation: