fix gin proxy load balance problem when nic is a lag port#2230
Open
YeSho-cpp wants to merge 1 commit into
Open
fix gin proxy load balance problem when nic is a lag port#2230YeSho-cpp wants to merge 1 commit into
YeSho-cpp wants to merge 1 commit into
Conversation
YeSho-cpp
force-pushed
the
dev
branch
4 times, most recently
from
9f9b8e4 to
8342cdb
Compare
…y gin proxy Signed-off-by: chenjiahui9 <chenjiahui9@xiaomi.com>
YeSho-cpp
changed the title
Collaborator
|
@YeSho-cpp did the recent rankStride change regress this case and your PR fixes the regression? |
Author
These are two separate issues. The recent rankStride fix addresses connectionType in ncclDevCommCreate not taking effect in gin proxy (#2137). The previous PR (a93cc03) fixed the issue in gdaki mode, while this new PR resolves the load balancing problem in proxy mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a QP load balance problem when using ROCE LAG (mode 4, 802.3 AD) with queue affinity policy by GIN proxy
Related Issues
#2136
Changes & Impact
Performance Impact
make gin proxy qp can full use of the dual uplink port of bonding ib device