Skip to content

remove unused 'rapids-date-string' in build scripts - #383

Merged
cryos merged 3 commits into
NVIDIA:mainfrom
jameslamb:remove-unused
Aug 7, 2026
Merged

remove unused 'rapids-date-string' in build scripts#383
cryos merged 3 commits into
NVIDIA:mainfrom
jameslamb:remove-unused

Conversation

@jameslamb

@jameslamb jameslamb commented Aug 6, 2026

Copy link
Copy Markdown
Member

rapids-date-string is used to set the environment variable RAPIDS_DATE_STRING, which is not used here.

It's included in a build script here, probably as an accident from copying patterns from RAPIDS projects.

This removes it.

Notes for Reviewers

Noticed this because as part of rapidsai/build-planning#218, I'm removing rapids-date-string (rapidsai/gha-tools#272). This prevents that change from breaking CI.

Summary by CodeRabbit

  • Chores
    • Updated the Conda Python build process by removing an unnecessary package sourcing step.
    • All other build, versioning, logging, retry, and cache reporting behavior remains unchanged.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 760db395-88f4-498d-a242-d8ee5d7f503f

📥 Commits

Reviewing files that changed from the base of the PR and between b555209 and cd93b56.

📒 Files selected for processing (1)
  • ci/build_conda_python.sh
💤 Files with no reviewable changes (1)
  • ci/build_conda_python.sh

📝 Walkthrough

Walkthrough

The Conda Python build script no longer sources rapids-date-string. Other build behavior remains unchanged.

Changes

Cohort / File(s) Summary
Conda build script
ci/build_conda_python.sh
Removes the rapids-date-string sourcing command.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the removal of the unused rapids-date-string dependency from the build scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Doc Preview CI
🚀 View pre-built docs at
https://NVIDIA.github.io/numbast/pr-preview/pr-383/

Preview will be ready when GitHub Pages deployment finishes.

@cryos
cryos merged commit 3ed14f2 into NVIDIA:main Aug 7, 2026
44 checks passed
@jameslamb
jameslamb deleted the remove-unused branch August 7, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants