fix(bdd): use exported profile trust for PKI - #1266
Merged
mikeyrcamp merged 1 commit intoAug 27, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
mikeyrcamp
force-pushed
the
test/bdd/pki-single-cluster
branch
2 times, most recently
from
August 27, 2026 16:33
fed00f0 to
079958b
Compare
mikeyrcamp
force-pushed
the
fix/issue-1254-pki-follow-up
branch
from
August 27, 2026 17:55
f55a27b to
4fc67aa
Compare
11 tasks
sbaum1994
added a commit
that referenced
this pull request
Aug 27, 2026
Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Follow up on #1075 by removing its BDD-only OpenBao trust rewrite. The PKI feature now validates and consumes the canonical trust data exported in the control-plane profile.
Additional Details
Why
#1075 added a helper that port-forwarded OpenBao and rewrote the compute environment after control-plane installation. The profile-driven registration fix in #1262 makes that second trust path unnecessary and risks letting the PKI test diverge from the operator workflow.
What changed
register-cluster.Customer Release Notes
Not customer visible. This change simplifies PKI BDD coverage.
Plan Summary
Not applicable.
Usage
Not applicable.
Testing
go test -short ./...intests/bdd: passed.golangci-lint run --config .golangci.yml --new-from-rev origin/test/bdd/pki-single-cluster ./...: passed with 0 new issues.golangci-lint run --config .golangci.yml ./...reports twoST1005findings indsl/manifests.gothat are present in the test(bdd): single-cluster PKI feature with a secured LLM invoke #1075 base and untouched by this PR.Notes
This PR is based on #1075 and depends on #1262 for the shared profile-registration and secure compute-fixture contract. It should be rebased after those prerequisite changes land.
References
Related Pull Requests
Dependencies
No third-party dependency, license, or NOTICE changes. Merge dependency: #1262.
For the Reviewer
Review the removal of the parallel trust path and the assertions that prove the installed values came from the exported profile.
For QA
Run
TestSingleClusterHelmfileLLMPKIafter #1262 is available on this branch.Issues
Relates to #1254
Checklist