Skip to content

fix(bdd): use exported profile trust for PKI - #1266

Merged
mikeyrcamp merged 1 commit into
test/bdd/pki-single-clusterfrom
fix/issue-1254-pki-follow-up
Aug 27, 2026
Merged

fix(bdd): use exported profile trust for PKI#1266
mikeyrcamp merged 1 commit into
test/bdd/pki-single-clusterfrom
fix/issue-1254-pki-follow-up

Conversation

@sbaum1994

Copy link
Copy Markdown
Collaborator

TL;DR

Follow up on #1075 by removing its BDD-only OpenBao trust rewrite. The PKI feature now validates and consumes the canonical trust data exported in the control-plane profile.

Additional Details

Why

#1075 added a helper that port-forwarded OpenBao and rewrote the compute environment after control-plane installation. The profile-driven registration fix in #1262 makes that second trust path unnecessary and risks letting the PKI test diverge from the operator workflow.

What changed

  • Assert that the exported profile contains management and transport bundle trust.
  • Initialize the selected CLI config before registration and pass it through register-cluster.
  • Assert the installed NVCA values keep insecure QUIC disabled and contain bundle trust with a fingerprint.
  • Remove the PKI-only trust rewrite script and its tests.
  • Update the feature wiring test to model the exported profile contract.

Customer Release Notes

Not customer visible. This change simplifies PKI BDD coverage.

Plan Summary

Not applicable.

Usage

Not applicable.

Testing

Notes

This PR is based on #1075 and depends on #1262 for the shared profile-registration and secure compute-fixture contract. It should be rebased after those prerequisite changes land.

References

Related Pull Requests

Dependencies

No third-party dependency, license, or NOTICE changes. Merge dependency: #1262.

For the Reviewer

Review the removal of the parallel trust path and the assertions that prove the installed values came from the exported profile.

For QA

Run TestSingleClusterHelmfileLLMPKI after #1262 is available on this branch.

Issues

Relates to #1254

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@sbaum1994
sbaum1994 requested a review from a team as a code owner August 27, 2026 16:23
@sbaum1994
sbaum1994 requested a review from nvjaxzin August 27, 2026 16:23
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5f7fb7dd-b614-4619-a40d-4e7f88ef8eee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@mikeyrcamp
mikeyrcamp force-pushed the test/bdd/pki-single-cluster branch 2 times, most recently from fed00f0 to 079958b Compare August 27, 2026 16:33
Replace the PKI-only trust rewrite helper with the canonical control-plane profile handoff. Consume the secure compute fixture contract from #1254 and assert the installed bundle trust.

Refs: #1254
Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
@mikeyrcamp
mikeyrcamp force-pushed the fix/issue-1254-pki-follow-up branch from f55a27b to 4fc67aa Compare August 27, 2026 17:55
@mikeyrcamp
mikeyrcamp merged commit ac8e11d into test/bdd/pki-single-cluster Aug 27, 2026
3 checks passed
@mikeyrcamp
mikeyrcamp deleted the fix/issue-1254-pki-follow-up branch August 27, 2026 18:00
sbaum1994 added a commit that referenced this pull request Aug 27, 2026
Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants