fix(otel): update x/crypto to v0.56.0 - #1612
Conversation
Regenerate the collector module metadata with golang.org/x/crypto v0.56.0 and raise the collector workspace minimum to Go 1.26, which the patched dependency requires. Closes #1608 Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
Risk assessmentOverall risk: Low to moderate.
Residual risk is concentrated in the non-hermetic Bazel collector build, which uses the host Go executable. That CI host must provide Go 1.26 or newer; the normal image build should confirm this. Runtime startup validation was not exercised locally because the existing validation script skips it on non-Linux hosts. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe OpenTelemetry Collector build configuration and module metadata now declare Go 1.26.0 and replace ChangesOpenTelemetry dependency update
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The collector now builds with Go 1.26 and x/crypto v0.56.0, addressing the dependency update while retaining the existing component configuration. No current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The reviewed changes update the OCB replacement and generated go.mod to x/crypto v0.56.0. Full compliance cannot be verified because go.sum and go.work are excluded by path filters, and those files are relevant to regenerated module metadata and the Go version update. Resolution Review the excluded files src/compute-plane-services/byoo-otel-collector/otelcol/go.sum and src/compute-plane-services/byoo-otel-collector/go.work, or provide equivalent evidence that module metadata was regenerated and the required Go version changes are complete. Confirm the reported binary, generated-output, and test validations. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🎉 This PR is included in version byoo-otel-collector-v0.2.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
TL;DR
Update the generated OpenTelemetry Collector module to use
golang.org/x/crypto v0.56.0, which fixes GO-2026-6354 and GO-2026-6355.Additional Details
v0.55.0tov0.56.0.go.modandgo.sum.x/crypto v0.56.0requires Go 1.26. The image Dockerfiles already build with Go 1.26.2.golang.org/x/cryptoremains under BSD-3-Clause, which is already allowed. No new dependency or NOTICE update is required.For the Reviewer
Please focus on the OCB replacement and the generated module metadata. The
godirective change is required by the updated module rather than an independent toolchain migration.For QA
make testpassed for every Go module in the subtree.make validate-otelconfigpassed all generated configuration validation. Runtime startup checks were skipped by the existing script on macOS../scripts/regenerate-otelcol.shpassed on a second run and produced no additional drift../tools/ci/check-go-versionpassed.go version -m _output/bin/otelcol-contribreportsgolang.org/x/crypto => v0.56.0.make linttarget is not present in this subtree's Makefile. A direct lint run reports existing findings in unchanged Go source files; this PR changes only dependency metadata.No additional QA is needed beyond the normal image build and scan.
Issues
Closes #1608
Checklist
Summary by CodeRabbit