[containerd-config-toml] set default runtime_type value if not present - #1969
Merged
Conversation
Coverage Report for CI Build 30931930163Coverage increased (+0.01%) to 43.626%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
tariq1890
force-pushed
the
set-default-runtime-type
branch
from
August 4, 2026 17:01
155f1a5 to
fcc99fd
Compare
henry118
approved these changes
Aug 4, 2026
cdesiniotis
reviewed
Aug 4, 2026
cdesiniotis
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1956
This PR addresses a scenario where valid albeit incomplete containerd config tomls may be provided as a base config. In this case, the
runtime_typefield was missing in the base config TOML, so the drop-in config TOML which defines the custom runtimes did not have theruntime_typepopulated. This led to errors starting up containers which used these custom runtimes.This PR changes that by automatically populating the
runtime_typefield with the default value in the new runtime handler blocks should theruntime_typebe empty