Skip to content

Make update-application-profile hook to ignore read-only fs error #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henry118 merged 1 commit into from
Aug 27, 2026
Merged

Make update-application-profile hook to ignore read-only fs error #2028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions cmd/nvidia-cdi-hook/update-application-profile/update-application-profile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@ package updateapplicationprofile

import (
"context"
"errors"
"fmt"
"os"
"regexp"
"syscall"

"github.com/urfave/cli/v3"

Expand Down Expand Up @@ -125,12 +127,19 @@ func run(_ context.Context, _ *cli.Command, cfg *options, logger logger.Interfac
return nil
}

if err := containerRoot.MkdirAll(applicationProfileDir, 0555); err != nil {
return fmt.Errorf("failed to create application profiles directory: %w", err)
}

if err := containerRoot.WriteFile(applicationProfileFile, buildApplicationProfileConfig(mask), 0444); err != nil {
return fmt.Errorf("failed to write application profile: %w", err)
if err = func() error {
if err := containerRoot.MkdirAll(applicationProfileDir, 0555); err != nil {
return fmt.Errorf("failed to create application profiles directory: %w", err)
}
if err := containerRoot.WriteFile(applicationProfileFile, buildApplicationProfileConfig(mask), 0444); err != nil {
return fmt.Errorf("failed to write application profile: %w", err)
}
return nil
}(); err != nil {
if !errors.Is(err, syscall.EROFS) {
return err
}
logger.Warningf("Ignoring read-only filesystem error: %v", err)
}

return nil
Expand Down
Loading