Skip to content

Conversation

@damonmcc
Copy link
Member

@damonmcc damonmcc commented Dec 29, 2025

related to #2082

hopefully we modernize how we handle these datasets before we need to build them next year (definitely said the same thing last year)

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.68%. Comparing base (ab686f5) to head (5b05058).

Additional details and impacted files
Files with missing lines Coverage Δ
dcpy/library/archive.py 83.33% <ø> (ø)
dcpy/library/cli.py 0.00% <ø> (ø)
dcpy/library/ingest.py 87.80% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@damonmcc damonmcc force-pushed the dm-ceqr-schools-2025 branch 2 times, most recently from d042a36 to a8b99da Compare December 29, 2025 17:00
@damonmcc damonmcc force-pushed the dm-ceqr-schools-2025 branch from a8b99da to f6a2509 Compare December 29, 2025 17:07
@damonmcc damonmcc changed the title build CEQR bchools 2026 build CEQR schools 2026 Dec 29, 2025
@damonmcc damonmcc force-pushed the dm-ceqr-schools-2025 branch from f6a2509 to 5b05058 Compare December 29, 2025 17:16
@damonmcc damonmcc requested a review from a team December 29, 2025 18:56
Copy link
Member Author

@damonmcc damonmcc Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I don't have to run a dev container to run builds that use geosupport, modeled on the in-use ceqr_dep_monthly.yml action. couldn't test this with workflow_dispatch untill it's merged

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure the LCGMS we get form CAPS for CEQR schools is different that what we get from the DOE website and use in the doe_lcgms ingest template. need to use library to archive this to the recipe postgres DB anyway so it wasn't worth resolving to a single ingest template to build the CEQR schools datasets

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we give this a different id then? Feels unlikely that it would happen by accident, but we still shouldn't have two different ingest/library templates with the same dataset id.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping this comment - other than that, good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants