[Fix] Fall back when bitmap context creation fails#74
Merged
Conversation
NachoSoto
marked this pull request as ready for review
July 11, 2026 03:49
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f38cd11cc8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Watch Chess production crash point
Dnhhtyya-umcNX4vnVhgsPtraps inImageInflaterRendererwhenCGContext(...)returnsnil. The renderer currently handles that recoverable resource-allocation failure withfatalError("Error creating bitmap context"), terminating the app on its background rendering queue.Falling back to the decoded image keeps the requested content available without forcing the app to terminate. A later image request can still attempt normal inflation again.
The CI workflow change repairs a pre-existing failure on
master: the unchanged workflow selected an iOS 26.5 simulator while forcing Xcode 26.1, whose iOS platform is no longer installed on the runner. The failure happened during destination selection before this branch's code compiled.Validation
swiftlint --config .swiftlint.yml --strictAsyncImageViewiOS simulator test suite: 60 passed, 0 failednilwithout a large allocation or OOMBuild and Testpassed with Xcode 26.5