Dockerized version#179
Open
francozacco wants to merge 4 commits into
Open
Conversation
Member
|
Thanks for your effort. But I'm wondering if the end-user is not aware of git. If he is using docker then probably |
Author
|
Hi Amit,
Yeap, It would be a problem if the end-user is not aware of git. I also
uploaded a docker image to my account in docker-hub, you can find it here
(https://hub.docker.com/r/francozacco/imglab) and I modified the
documentation to account for these changes. But now I don't have the time
to follow the steps to request an official image uploaded to docker-hub,
I'm sorry 🙁. Let me know what you think.
|
Member
|
I appreciate your work. But we can't link any 3rd party code right now due to security reasons. But I'll think about it. However, now I'm thinking about its need. Currently, people just need to open it in their browsers once and it perfectly works offline. So no load on their system and no technical knowledge is required. I feel we should focus more on the required features than good to have. |
R0nni333
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
Added docker files to run the server on a docker container. I also added documentation explaining how to run the docker container.
Type
Please mention the type of PR