Adding end-to-end tests for subsidized RBF Bitcoin transfers. - #438
Open
olga24912 wants to merge 3 commits into
Open
Adding end-to-end tests for subsidized RBF Bitcoin transfers.#438olga24912 wants to merge 3 commits into
olga24912 wants to merge 3 commits into
Conversation
kiseln
approved these changes
Oct 19, 2025
| bridge-cli testnet near-fin-transfer-btc \ | ||
| --chain btc \ | ||
| -b {params.btc_tx_hash} \ | ||
| -v 0 \ |
Contributor
There was a problem hiding this comment.
Perhaps it's better to use full name since it's hard to tell what this means
Contributor
|
@olga24912 should I close #419 since rbf mechanism changed? |
Contributor
Author
No, this is the correct PR — the old mechanism is still in use. |
frolvanya
approved these changes
Oct 22, 2025
frolvanya
left a comment
frolvanya
left a comment
Contributor
There was a problem hiding this comment.
Please fix merge conflict
| return open(str(filename)).readlines()[-1].split('"')[-2] | ||
| with open(str(filename), "r", encoding="utf-8") as f: | ||
| for line in f: | ||
| if 'tx_hash="' in line: |
Contributor
There was a problem hiding this comment.
Are you sure that this won't break other steps? If I remember correctly it's used in combination with this (different format):
Contributor
Okay, then I'll fix issues with merge conflict later in my PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.