Skip to content

Conversation

@bainco
Copy link
Member

@bainco bainco commented Dec 17, 2025

Some quick fixes to get the automated test suite working again:

  • Update GitHub-actions so that they...
    • install the sr and resource extensions
    • install r and the spatstat package on the build environment to support sr extensions
  • Changes for sr extension:
    • Renames Code Examples/Extensions Example/sr/plotting.nlogox to Code Examples/Extensions Example/sr/Plotting.nlogox to match .gitignore entries (though perhaps this should be renamed to Plotting Example since all the other example models match that nomenclature)
    • Renotarize Example 1.nlogox in sr examples
    • Add Boxplot Example exemption from "no code in INFO TABs" test
  • Add 1 questionable exemption to the ViewTests, specifically whether or not the computed view size matches the saved view size.
  • Fixes for 3D Sample model: 3D Maze
    • manual preview needed
    • added manual preview but added preview commands for model checksums check
    • disabled buttons until ticks start

Note: there's a weird Graphics Environment exception popping up in the actions logs (Exception in thread "AWT-EventQueue-0" java.awt.HeadlessException). Not sure what that's all about but worth investigating.

@TheBizzle
Copy link
Member

💪 Holy champ! What the what?! 🤯

@bainco bainco changed the title [wip?] Fix automated test suite Fix automated test suite Dec 17, 2025
@TheBizzle
Copy link
Member

@bainco , very cool that you did this! 😎 🙇‍♂️

I fixed the befuddling text that you sidelined for the Interstitial Diffusion model. The logic behind the test is as follows:

A View widget's width is computable by (world-width * patch-size) + 4 pixels (and similar logic will apply for height). The 4 is for 2px of border on either side of the widget.

However, in the .nlogox file, the <view> tag contains all of that information, and then also gives a specific width number that it wants to be laid out with. If its stated width is not the same as its computed width (from the formula above), then there's something wrong with the information in that tag.

So, indeed, I think this test did actually catch a very minor bug. It seems that the widget's stated height and width were not factoring in the border. I've fixed it in this PR now, and everything looks uncontroversial to me, so I'll merge this and rebase your other PRs onto it.

@TheBizzle TheBizzle merged commit f39a791 into main Dec 18, 2025
2 checks passed
@TheBizzle TheBizzle deleted the test-quick-fixes branch December 18, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants