Skip to content
This repository was archived by the owner on Dec 19, 2025. It is now read-only.

Copy tags from existing to next ASG#514

Closed
e0d wants to merge 1 commit into
Netflix:masterfrom
edx:e0d/copy-tags-on-create-asg
Closed

Copy tags from existing to next ASG#514
e0d wants to merge 1 commit into
Netflix:masterfrom
edx:e0d/copy-tags-on-create-asg

Conversation

@e0d
Copy link
Copy Markdown
Contributor

@e0d e0d commented Mar 17, 2014

This PR causes existing tags assigned to an ASG to be copied when a new ASG is created. This is useful in cases where tags are assigned to resources outside of Asgard via, say, Cloudformation or the AWS CLI.

Tags with a key that starts with "aws" are dropped as that key prefix is reserved.

Fixing missing imports

filtering tags.

fixing npe.

code narc

test for tag copy
@cloudbees-pull-request-builder
Copy link
Copy Markdown

asgard-pull-requests #343 SUCCESS
This pull request looks good

@joesondow
Copy link
Copy Markdown
Contributor

See #380 for a discussion of the outstanding issues with ASG tagging that we need to iron out.

@e0d e0d closed this Jan 31, 2016
@e0d e0d deleted the e0d/copy-tags-on-create-asg branch January 31, 2016 01:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants