fix(ns-ipsec): synchronize disabled state for existing routes in edit tunnel API#1567
Open
m-dilorenzi wants to merge 2 commits intomainfrom
Open
fix(ns-ipsec): synchronize disabled state for existing routes in edit tunnel API#1567m-dilorenzi wants to merge 2 commits intomainfrom
m-dilorenzi wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes improvements to the management of route state when editing an IPsec tunnel in the
ns.ipsectunnelmodule. The main focus is on ensuring that the enabled/disabled status of the tunnel is consistently applied to all associated routes.Route state synchronization:
route_disabledvariable to centralize the logic for determining route disabled state based on the tunnel'senabledargument.route_disabledvariable for setting the disabled state, ensuring consistency.uci_set_if_changedto update only when necessary.Closes: #1558