Repository navigation
Thapa2025: declare sessions per the loader-default rule (b) - #1222
Merged
bruAristimunha merged 1 commit intoOct 5, 2026
Merged
Conversation
…rule b)
sub-02 and sub-17 stopped after a single session; the released cohort has
{1: 2 subjects, 2: 16 subjects, 3: 5 subjects}, 49 sessions total. Per
Bruno's rule (b), the declared count must describe what the loader
returns by default. Follow the minimum-sessions convention already used
by PardoGarcia2026 and declare sessions_per_subject=1 (both in METADATA
and super().__init__), with the actual distribution kept in the
docstring. Behaviour-preserving: data_path still returns every session
present on disk, and the n_sessions-dependent get_data iteration is
unchanged. Test test_thapa_transport_and_missing_sessions now asserts
n_sessions == 1.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the counting rule Bruno fixed on 2026-10-05:
sessions_per_subjectdescribes what the loader returns by default, the cohort distribution goes in the docstring. Thapa2025 released 23 subjects with 49 sessions ({1 session: 2 subjects, 2: 16, 3: 5}, matching the paper and the converted BIDS tree on nm000324); the docstring and metadata now say so instead of a flat '3'. The NEMAR deposit README (nm000324) and PardoGarcia2026's (nm000309) were updated the same way; PardoGarcia2026's loader already followed the rule. Synthetic test adjusted; no behaviour change.