test(nemar): wire Vagaja2023 nemar_id=nm000292, drop from NEMAR_ID_PENDING - #1230
Merged
bruAristimunha merged 3 commits intoOct 6, 2026
Merged
Conversation
…NDING nm000292 was published 2026-10-05; MOABB's NEMAR reader path verified end-to-end on Voyager (k8s job, provider pinned to 'nemar', no upstream fallback allowed): _download_nemar(subject=3) fetched 15 BIDS files genuinely from data.nemar.org. The deposit's sourcedata/ (pushed directly to main, not a pending PR -- commit caf4a627) is not yet served by NEMAR's own index (a subject-agnostic, no-filter nemar.download(scope='sourcedata') for nm000292 still returns SelectionError: no files matched), so get_data() itself (which depends on the sourcedata mirror for this loader) does not yet succeed through NEMAR; this is a server-side index lag, not a MOABB code or git-content issue, and is expected to resolve once NEMAR's index catches up. No loader scientific change. Test-only + one nemar_id class attribute. Evidence: .pr-audits/w41/N5B-REPORT.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set
nemar_id = "nm000292"onVagaja2023and drop it fromNEMAR_ID_PENDINGin
moabb/tests/test_datasets.py(same pattern as #1223). nm000292 waspublished on NEMAR on 2026-10-05.
No loader scientific change. Test-only + one class attribute.
No changelog entry (please apply the
no changeloglabel).Evidence
Reader-proof run as a k8s Job on Voyager,
origin/developHEAD3888687e0,MOABB_DOWNLOAD_PROVIDERpinned tonemar(no upstream fallback allowed bythat pin -- see
download()/_prefetch_nemar_sourcedata()inmoabb/datasets/base.py), against the published deposit nm000292:nemar.download()-based BIDS fetch (_download_nemar(subject=3), the samecall
sourcedata_path/get_dataroute through) succeeded, genuinelyreaching
data.nemar.org(15 files fetched, no upstream host contacted).Vagaja2023().sourcedata_path(subject=3)fails right now withNemarDownloadErrorfrom_sourcedata_files_for_subject(
moabb/datasets/download.py:436) -- traced to NEMAR's own BIDS querylayer returning
SelectionError: No files matched the BIDS query: scope=sourcedata, reproduced even with a subject-agnostic, no-filternemar.download(dataset="nm000292", scope="sourcedata"). This is nota subject-match bug or a pending PR:
sourcedata/is already committed tonemarDatasets/nm000292'smainbranch (commitcaf4a627, "Addsourcedata (original files) with provenance manifest", 2026-10-05 21:44
UTC;
sourcedata_provenance.jsonconfirmed as a plain git blob, mode100644) and there is no open PR on that repo (main,git-annex,synced/git-annexonly) -- NEMAR's served index for the dataset simplyhas not picked up that commit yet.
get_data()depends on the sourcedatamirror for this (non-BIDS-native) loader, so it does not yet succeed
through NEMAR either, for the same underlying reason.
Control (published, already-wired
Pressel2016/nm000258, same Job, samestrict provider pin): both
get_data(subjects=[1])andsourcedata_path(subject=1)passed -- 1 session/1 run, shape[7, 2483088]; sourcedata 1 file, 130,783,392 bytes, sha256 matched againstthe deposit's own manifest.
Full report with exact commands, logs and JSON results:
.pr-audits/w41/N5B-REPORT.md(not committed to this PR; internal tracking).Tests
Not merging
Per the parent task's contract, this PR is opened for review only; the
parent merges on green.
sourcedata_path/get_datathrough NEMAR for thisdataset will start passing once NEMAR's index catches up with the already
-committed
sourcedata/tree -- no further MOABB-side change is expected tobe needed for that.