-
Notifications
You must be signed in to change notification settings - Fork 0
[NOOK-176] OCR 장소 후보 추출 상한 확대 #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # NOOK-176 OCR 장소 후보 탈락률 개선 | ||
|
|
||
| ## 목적 | ||
|
|
||
| OCR transcript에 다수의 장소명이 포함된 게시물에서 장소 clue 추출 단계의 개수 제한 때문에 후보가 과도하게 탈락하지 않도록 한다. | ||
|
|
||
| ## 범위 | ||
|
|
||
| - 장소 clue 반환 상한을 20개에서 60개로 확대한다. | ||
| - 본문에 `52곳`처럼 20개를 초과하는 기대 장소 개수가 있어도 OCR fallback과 recall recovery 판단에 사용한다. | ||
| - OpenAI structured output schema, 출력 토큰 한도, 프롬프트의 장소 개수 상한을 함께 조정한다. | ||
|
|
||
| ## 제외 범위 | ||
|
|
||
| - OCR provider 교체 | ||
| - 게시물 이미지 저장 흐름 변경 | ||
| - DB 스키마 변경 | ||
|
|
||
| ## 검증 | ||
|
|
||
| - `./gradlew :nook-api-application:test --tests org.every.nook.api.application.place.ProcessPlaceParsingJobUseCaseTest` | ||
| - `./gradlew check` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a post now yields dozens of clues,
resolveCluescan perform up to four sequential provider searches plus candidate selection per clue, so processing can exceed the default one-minute lease. The presentation worker still dispatches outstanding jobs every 10 seconds, whilePlaceParsingPersistenceAdapter.findOutstandingmarks aPROCESSINGjob available solely from its lastupdatedAt; there is no heartbeat during resolution. A second worker can therefore reclaim the same high-count job while the first is still running, causing duplicate provider work and competingcompletetransactions that can hitpost_placesuniqueness constraints or overwrite the job status. Increase/renew the lease or otherwise prevent reclamation while processing the newly supported workload.Useful? React with 👍 / 👎.