Repository navigation
Conversation
wine renamed the constant between 11.0 and 11.15 and its value changed with it: DONT_RESOLVE_DLL_REFERENCES is 0x1, LDR_DONT_RESOLVE_REFS is 0x2. build_module carries the same source line either way, so the gate search has to accept both. Without this, resolve.py reports "no module-flags gate above the MODREF flag test" for anything built from wine 11.0, CrossOver 26.3 among them. With it, 26.3's i386 ntdll resolves and steals the gate plus its jne, the same shape the pinned Rosetta i386 build already uses.
Contributor
Author
|
dupe of broader resolution in dev branch, a9c6dc3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wine renamed the constant between 11.0 and 11.15 and its value changed with it: DONT_RESOLVE_DLL_REFERENCES is 0x1, LDR_DONT_RESOLVE_REFS is 0x2. build_module carries the same source line either way, so the gate search has to accept both.
Without this, resolve.py reports "no module-flags gate above the MODREF flag test" for anything built from wine 11.0, CrossOver 26.3 among them. With it, 26.3's i386 ntdll resolves and steals the gate plus its jne, the same shape the pinned Rosetta i386 build already uses.