Repository navigation
Conversation
Downloads the pinned 20260125 release on first use, runs it unattended with the verbs the user types, and writes its output to winetricks.log in the prefix. Refuses while the game is running, and refuses annihilate and prefix=.
Owner
|
Merged, I'll be doing a UI for picking fonts/redists to install soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
People keep needing vcrun2022 or corefonts in one game's prefix, and CrossOver doesn't ship winetricks. The Tools menu now has a Winetricks item that asks for verbs and runs them in the selected prefix.
Tools menu / prefix context menu Run Program… + Winetricks… asks for verbs, e.g. "vcrun2022 corefonts" Wine Configuration / Registry Editor / Task ManagerThe script is downloaded rather than vendored because it's LGPL. cabextract comes from the runner's own bin, which is already on PATH.
annihilateis blocked because under-qit wipes the prefix and its saves without asking. Delete Prefix already covers that, with a warning.The download error text no longer says "Valve" when the file comes from somewhere else.
Evidence
After: in the built app, on Zuma Deluxe:
comicsansdownloaded its file, ran the runner's cabextract, and putcomic.ttfandcomicbd.ttfin the prefix's Fonts. The bottom bar said done.notaverbshowed Failed with the path towinetricks.log.win10andcomicsansboth passed, and the log had no wine arch warnings.PrefixToolsTests, "Winetricks refuses before it runs when it cannot work or would leave the prefix". It covers empty input,annihilate,prefix=and a missing runner, and checks that nothing runs. Full app suite: same results as the base branch.Merge Danger
Door: two-way
Only runs when someone picks it. What it installs stays in that one prefix.
Blast Radius: small
One new menu item.
eachInTurnin PrefixesModel now takes async work, and the existing sync callers still compile unchanged.