Repository navigation
Add Simplified Chinese localization with English fallback - #72
Closed
KameraZhao wants to merge 1 commit into
Closed
KameraZhao wants to merge 1 commit into
KameraZhao wants to merge 1 commit into
Conversation
KameraZhao
marked this pull request as ready for review
October 9, 2026 14:30
Owner
|
Thank you so much. I will merge this for the next release 🇨🇳 😄 |
Owner
|
Thank you, merged as e1f0e68 with you as the author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Simplified Chinese localization with English fallback
Summary
Add Simplified Chinese support to the native NotProton app and the injected
Steam compatibility panel without creating a separate release channel.
backup controls and explicit save-data-loss warnings.
than force Chinese. Keep English fallback and existing English test assertions.
.app, including SwiftPM'slowercased localization directory names.
the browser language. No changes to option keys, backend values or gate anchors.
Based on upstream
mainat8593594(v1.1.3).Scope
The original macOS minimum, official Sparkle feed, signing public key, release
workflow and English branding are retained. This PR intentionally does not
include the separate fork's macOS 15 backport, Chinese-only defaults, disabled
updater, or source-sync automation.
Validation
Passed locally on macOS 15.8 using Swift 6.2.3 / Command Line Tools:
make localizationcheck: all 401 translations, English fallback, localematching, interpolation, literal inserted values and destructive warnings.
explicit language overrides; official updater configuration retained.
make panel-behavior: original English behavior, switching, launch options,shell behavior, migration and new bilingual tests for both emitted shapes.
make webpatch-fixtures: both shapes, 14 gates, 5 fixes, 14 chunk paths andthree fixtures; anchors intact and unsupported drift refused.
callscheck,compatcheck,compatsvc-check,launch-shell,envcheck,buildcheck,settingscheck,routecheck,bridgecheck,gamedrivecheck,seedcheck.git diff --check.Not verified:
swift testfails atupstream's retained
ToolbarItemGroup.visibilityPriorityAPI with the installedSDK. The local Command Line Tools also lack the Swift
Testingmodule.These unrelated upstream/toolchain constraints were not changed in this PR.
real game launches and an end-to-end signed update.
Please run the existing app workflow and manually review both languages before
merging. If useful, I can split the native-app and Steam-panel changes for review.