Fix inconsistent add torrent dialog window width #2975
Merged
Merged
Conversation
drrako
changed the title
Contributor
|
JFYI, pull request should probably be based on develop branch. |
Contributor
Author
|
@allixx I considered it a simple enough bug fix for the |
Collaborator
|
@drrako can you submit over develop? I'm testing everything there, even if it's a trivial thing that makes my life a bit easier. |
Contributor
Author
|
@xirvik It is rebased against the develop now. |
xirvik
added a commit
to xirvik/ruTorrent
that referenced
this pull request
May 3, 2026
Use width instead of max-width/min-width so dialog has consistent size at each breakpoint instead of fluctuating with content. Cherry-pick of upstream PR Novik#2975 by @drrako.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a minor issue in the add torrent dialog, where its size changes depending on the selected input torrent file (especially in Firefox). Some long torrent file names with many space breaks can significantly stretch the modal window.
I've also updated styles so this window always take 95% of the viewport on a smaller screens.