Skip to content

[19.0][FIX] server_environment: use correct invisible attribute for _is_editable field #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
em230418 wants to merge 1 commit into
base: 19.0
Choose a base branch
from
+5 −1
Open

[19.0][FIX] server_environment: use correct invisible attribute for _is_editable field #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion server_environment/models/server_env_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,10 +316,14 @@ def _server_env_view_set_readonly(self, view_arch):
# files have a key set for this field
elem.set("readonly", f"not {is_editable_field}")
if not view_arch.findall(field_xpath % is_editable_field):
if view_arch.tag == "list":
invisble_kwargs = {"column_invisible": "1"}
else:
invisble_kwargs = {"invisible": "1"}
# add the _is_editable fields in the view for the 'attrs'
# domain
view_arch.append(
etree.Element("field", name=is_editable_field, invisible="1")
etree.Element("field", name=is_editable_field, **invisble_kwargs)
)
return view_arch

Expand Down
Loading