Repository navigation
[14.0] [BACKPORT] odoo_test_xmlrunner + fixes - #3126
paradoxxxzero wants to merge 3 commits into
Conversation
Kev-Roche
left a comment
Kev-Roche
left a comment
There was a problem hiding this comment.
LGTM
Functional review on gitlab
| "website": "https://github.com/OCA/server-tools", | ||
| "category": "Tools", | ||
| "sequence": 20, | ||
| "auto_install": True, |
There was a problem hiding this comment.
| "auto_install": True, | |
| "auto_install": False, |
See : #3156
390bd46 to
ab74474
Compare
OCA-git-bot
added
series:14.0
mod:odoo_test_xmlrunner
|
hi @metaminux, @paradoxxxzero : could you fix #3126 (review) ? |
- It doesn't make sense to make this module auto installable. - As the module depends only on 'base' AND introduces a new external dependency to an extra library (unittest-xml-reporting) all the instances that are cloning server-tools repo will have trouble, because it will not be possible to install this module, due to missing dependency
ab74474 to
f47acaf
Compare
Hello @legalsylvain I just cherry-picked your commit on 17.0. This should do the job... Regards, |
| { | ||
| "name": "Unittest xUnit reports", | ||
| "version": "14.0.1.0.0", | ||
| "depends": [], |
There was a problem hiding this comment.
I think you should depend on "base". I never saw a module without dependency.
There was a problem hiding this comment.
I think you should depend on "base". I never saw a module without dependency.
There are... for example : pydantic/manifest.py
I also found modules where the depends section is just removed...
But looking at https://www.odoo.com/documentation/20.0/developer/reference/backend/module.html#manifest you're probably true.
I'll fix that, thanks
Also implement a better patch and merge test results.
f47acaf to
fe14dbb
Compare
|
@legalsylvain "base" is back ✅ |
6 participants
Backport of #2957 with a more elegant patch handling tests results merging which fixes the tests result display and the process exit code (1 if tests failed)