Skip to content

[16.0][FIX] survey_certification_branding#214

Open
edescalona wants to merge 1 commit into
OCA:16.0from
BinhexTeam:16.0-fix-survey_certification_branding
Open

[16.0][FIX] survey_certification_branding#214
edescalona wants to merge 1 commit into
OCA:16.0from
BinhexTeam:16.0-fix-survey_certification_branding

Conversation

@edescalona
Copy link
Copy Markdown

@edescalona edescalona commented Feb 4, 2026

@BinhexTeam

When a portal user registers and completes a certification, the following errors occur:

  • When the text in the "Company Name" field in the "Certification Mark" section and the survey name are too long, they overlap with the date and image values ​​for the "Certification Mark." Therefore, limiting these to 100 and 180 characters, respectively, is recommended.
  • The image configured in the "Certification Mark" section of the survey is not displayed.

This change request resolves both of these issues.

Survey title:
image

Company name (Certification branding)
image

[FIX] Before (Certification Modern)
image

[FIX] Before (Certification Classic)
image

After (Certification Modern)
image

After (Certification Classic)
image

@edescalona edescalona force-pushed the 16.0-fix-survey_certification_branding branch from 6e190f9 to 6582955 Compare February 4, 2026 20:19
@edescalona edescalona marked this pull request as ready for review February 4, 2026 20:32
@edescalona
Copy link
Copy Markdown
Author

ping @rrebollo

Comment thread survey_certification_branding/README.rst
@edescalona edescalona force-pushed the 16.0-fix-survey_certification_branding branch from 6582955 to 3d5167f Compare February 5, 2026 22:39
@edescalona
Copy link
Copy Markdown
Author

ping @atgalvez08 @rrebollo

Copy link
Copy Markdown

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edescalona Good catch! Did you consider handling the text overflow with CSS (SCSS)?

@edescalona
Copy link
Copy Markdown
Author

Hi @rrebollo , yes we looked into that case with CSS, but it's not the best approach here. The goal is to avoid very long content and the certificate stretching across two pages.

@edescalona
Copy link
Copy Markdown
Author

Hi @sbidoul , could you please review @pedrobaeza comment or tell us how to proceed? Thanks

@pedrobaeza
Copy link
Copy Markdown
Member

I think that if you update copier template to the latest one, now it's included.

@edescalona edescalona force-pushed the 16.0-fix-survey_certification_branding branch from 3d5167f to ec46391 Compare March 6, 2026 23:18
@edescalona
Copy link
Copy Markdown
Author

ping @pedrobaeza @sbidoul

@edescalona edescalona requested a review from pedrobaeza April 20, 2026 17:19
Copy link
Copy Markdown

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friend, you need to remove the index.html and README.rst files from the commit—not from the filesystem. Also, the pre-commit-config.yaml approach is not the right way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants