[19.0][MIG] partner_survey#220
Open
mav-adhoc wants to merge 30 commits into
Open
Conversation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: survey-12.0/survey-12.0-partner_survey Translate-URL: https://translation.odoo-community.org/projects/survey-12-0/survey-12-0-partner_survey/
Currently translated at 100.0% (6 of 6 strings) Translation: survey-12.0/survey-12.0-partner_survey Translate-URL: https://translation.odoo-community.org/projects/survey-12-0/survey-12-0-partner_survey/pt_BR/
Currently translated at 100.0% (6 of 6 strings) Translation: survey-12.0/survey-12.0-partner_survey Translate-URL: https://translation.odoo-community.org/projects/survey-12-0/survey-12-0-partner_survey/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: survey-13.0/survey-13.0-partner_survey Translate-URL: https://translation.odoo-community.org/projects/survey-13-0/survey-13-0-partner_survey/
Currently translated at 100.0% (11 of 11 strings) Translation: survey-13.0/survey-13.0-partner_survey Translate-URL: https://translation.odoo-community.org/projects/survey-13-0/survey-13-0-partner_survey/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: survey-15.0/survey-15.0-partner_survey Translate-URL: https://translation.odoo-community.org/projects/survey-15-0/survey-15-0-partner_survey/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: survey-17.0/survey-17.0-partner_survey Translate-URL: https://translation.odoo-community.org/projects/survey-17-0/survey-17-0-partner_survey/
Currently translated at 100.0% (10 of 10 strings) Translation: survey-17.0/survey-17.0-partner_survey Translate-URL: https://translation.odoo-community.org/projects/survey-17-0/survey-17-0-partner_survey/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: survey-18.0/survey-18.0-partner_survey Translate-URL: https://translation.odoo-community.org/projects/survey-18-0/survey-18-0-partner_survey/
Currently translated at 100.0% (10 of 10 strings) Translation: survey-18.0/survey-18.0-partner_survey Translate-URL: https://translation.odoo-community.org/projects/survey-18-0/survey-18-0-partner_survey/es/
3f2f508 to
9a6f3d8
Compare
|
LGTM |
les-adhoc
approved these changes
May 7, 2026
Contributor
|
This PR has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes applied:
models/res.partner:
Line 34: resolves the deprecation warning that causes the CI failure. The return format changes from dicts to tuples.
Line 30: the field depends on actual survey input records, not is_company.
Line 49: it reads those two fields, so it must depend on them.
Line 60: was incorrectly assigning to the whole recordset instead of the current record in the loop.