[16.0][ADD] website_recaptcha_v2_form #1076
Conversation
edescalona
force-pushed
the
16.0-add-website_recaptcha_v2_form
branch
from
74618c9 to
8b4f216
Compare
christian-ramos-tecnativa
left a comment
christian-ramos-tecnativa
left a comment
There was a problem hiding this comment.
Thanks for your contribution, check my comments please and remember to squash your commits into one.
edescalona
force-pushed
the
16.0-add-website_recaptcha_v2_form
branch
from
cf7f6d2 to
e07469c
Compare
jorgeglez1990
left a comment
jorgeglez1990
left a comment
There was a problem hiding this comment.
Greetings,
It has been functionally tested, and it works correctly except when, on /web/login, we log in without verifying the reCAPTCHA, which results in a 500: Internal Server Error.
hello @jorgeglez1990 I'll check it out now, thanks for your cooperation. |
|
Hi @nobuQuartile , I solved the error you mentioned. When I can, please check and confirm. Thanks. |
Hi @edescalona, I checked and confirmed the problem is solved at the ruboat. Thanks. |
edescalona
force-pushed
the
16.0-add-website_recaptcha_v2_form
branch
from
075722c to
bce9e9b
Compare
edescalona
force-pushed
the
16.0-add-website_recaptcha_v2_form
branch
from
bce9e9b to
1c2ed62
Compare
Honeyxilia
left a comment
Honeyxilia
left a comment
There was a problem hiding this comment.
Hello - first of all, thank you for the work on this module to add a basic controller functionnality c:
I had a couple of questions before approving the changes
| def valid_recaptcha(self, values): | ||
| valid, message = self.is_recaptcha_v2_valid(values) | ||
| if not valid: | ||
| raise AccessDenied(message) | ||
| return True |
There was a problem hiding this comment.
I think this wrapper method is not really necessary, as it doesn't accomplish much more than link an AccessDenied exception with the error message, which should already be considered a fail state.
=> What is the reasonning behind this wrapper, that can't be fulfilled using the return tuple of is_recaptcha_v2_valid ?
There was a problem hiding this comment.
Hi @Honeyxilia , thanks for your comments. Basically, I want to show the message returned by the recaptcha verification as access denied, and then capture the exception in the controller.
website_recaptcha_v2_form/views/auth_signup_login_templates.xml
Outdated
Show resolved
Hide resolved
…orm snippets and also in the login, password reset and register forms. [FIX] Tests [FIX] Ttests [IMP] Add new tests [IMP] Add new tests [IMP] website_recaptcha_v2_form: Update site-key values from the write method.Tests. [FIX] Valid views with recaptcha [IMP] Add tests [IMP] Add tests [IMP] Update sitekey on web forms created by changing settings [IMP] Add tests [IMP] Add tests [FIX] Tests [FIX] Tests [ADD] Tests [FIX] Tests [FIX] Tests [ADD] Tests [ADD] Tests [FIX] Tests [ADD] Tests [ADD] Tests [REM] Tests [ADD] Tests [ADD] Tests [ADD] Tests [FIX] Rename import class [FIX] website_recaptcha_v2_form: Readme [FIX] website_recaptcha_v2_form: Correcting CONTRIBUTORS file structure [FIX] website_recaptcha_v2_form: Remove comments [IMP] website_recaptcha_v2_form: Change name class [IMP] Valid send data website form with recaptcha [IMP] Readme [IMP] Readme [FIX] Tests [IMP] website_recaptcha_v2_form: Change name template
edescalona
force-pushed
the
16.0-add-website_recaptcha_v2_form
branch
from
1c2ed62 to
fe773e2
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
6 participants
@BinhexTeam
Adding recaptcha version 2 for the form snippets and also in the login, password reset and register forms.